containers: allow Ubuntu2404 for AKS os_sku#32026
Closed
steveej wants to merge 1 commit intohashicorp:mainfrom
Closed
containers: allow Ubuntu2404 for AKS os_sku#32026steveej wants to merge 1 commit intohashicorp:mainfrom
steveej wants to merge 1 commit intohashicorp:mainfrom
Conversation
Changes: - allow `Ubuntu2404` in the AKS node pool `os_sku` schema validation list - allow `Ubuntu2404` in the AKS default node pool `os_sku` schema validation list - add offline schema tests that lock in `Ubuntu2404` acceptance for both code paths Validation: - go test ./internal/services/containers -run "TestKubernetes.*Ubuntu2404" -count=1
sreallymatt
requested changes
Mar 25, 2026
| string(agentpools.OSSKUAzureLinuxThree), | ||
| string(agentpools.OSSKUUbuntu), | ||
| string(agentpools.OSSKUUbuntuTwoTwoZeroFour), | ||
| string(agentpools.OSSKUUbuntuTwoFourZeroFour), |
Collaborator
There was a problem hiding this comment.
This needs to be added to the documentation for azurerm_kubernetes_cluster_node_pool
| string(agentpools.OSSKUAzureLinuxThree), | ||
| string(agentpools.OSSKUUbuntu), | ||
| string(agentpools.OSSKUUbuntuTwoTwoZeroFour), | ||
| string(agentpools.OSSKUUbuntuTwoFourZeroFour), |
Collaborator
There was a problem hiding this comment.
This needs to be added to the documentation for azurerm_kubernetes_cluster
| @@ -0,0 +1,42 @@ | |||
| // Copyright IBM Corp. 2014, 2025 | |||
Collaborator
There was a problem hiding this comment.
This can be removed, we don't unit test basic ValidateFuncs like validation.StringInSlice
Collaborator
|
superseded by #32070 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This is a follow-up to the AKS containerservice API update in #31401.
AKS now supports
Ubuntu2404for both:azurerm_kubernetes_cluster_node_pool.os_skuazurerm_kubernetes_cluster.default_node_pool.os_skubut the provider schema validation still rejects that value in both code paths.
This change updates the validation lists to accept
Ubuntu2404and adds small offline tests that lock in the expected schema behavior for both resources.This is intended to close the remaining schema gap reported in #29827.
PR Checklist
Changes to existing Resource / Data Source
Testing
Local test run:
I did not run Azure acceptance tests for this change because the patch is limited to schema validation and the added tests are offline schema-level coverage.
Change Log
azurerm_kubernetes_cluster- supportUbuntu2404indefault_node_pool.os_sku[support for os_sku Ubuntu2404 #29827]azurerm_kubernetes_cluster_node_pool- supportUbuntu2404inos_sku[support for os_sku Ubuntu2404 #29827]This is a (please select all that apply):
Related Issue(s)
Fixes #29827
AI Assistance Disclosure
AI was used to help identify the remaining schema-validation call sites and draft the initial offline schema tests. The final patch and local validation were reviewed and run manually.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
No changes to security controls.