Add md5authenticationkeys to google_compute_router (#13472) (#22101)

[upstream:28406153e8f813fac331bca8856601bbb3769929]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/13472.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: Added `md5_authentication_keys` to `google_compute_router`
+```

google/services/compute/resource_compute_router.go

@@ -196,6 +196,27 @@ The default is 20.`,
 				Description: `Indicates if a router is dedicated for use with encrypted VLAN
 attachments (interconnectAttachments).`,
 			},
+			"md5_authentication_keys": {
+				Type:        schema.TypeList,
+				Optional:    true,
+				Description: `Keys used for MD5 authentication.`,
+				MaxItems:    1,
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"key": {
+							Type:        schema.TypeString,
+							Required:    true,
+							Description: `Value of the key used for MD5 authentication.`,
+						},
+						"name": {
+							Type:     schema.TypeString,
+							Required: true,
+							Description: `Name used to identify the key. Must be unique within a router.
+Must be referenced by exactly one bgpPeer. Must comply with RFC1035.`,
+						},
+					},
+				},
+			},
 			"region": {
 				Type:             schema.TypeString,
 				Computed:         true,
@@ -262,6 +283,12 @@ func resourceComputeRouterCreate(d *schema.ResourceData, meta interface{}) error
 	} else if v, ok := d.GetOkExists("encrypted_interconnect_router"); !tpgresource.IsEmptyValue(reflect.ValueOf(encryptedInterconnectRouterProp)) && (ok || !reflect.DeepEqual(v, encryptedInterconnectRouterProp)) {
 		obj["encryptedInterconnectRouter"] = encryptedInterconnectRouterProp
 	}
+	md5AuthenticationKeysProp, err := expandComputeRouterMd5AuthenticationKeys(d.Get("md5_authentication_keys"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("md5_authentication_keys"); !tpgresource.IsEmptyValue(reflect.ValueOf(md5AuthenticationKeysProp)) && (ok || !reflect.DeepEqual(v, md5AuthenticationKeysProp)) {
+		obj["md5AuthenticationKeys"] = md5AuthenticationKeysProp
+	}
 	regionProp, err := expandComputeRouterRegion(d.Get("region"), d, config)
 	if err != nil {
 		return err
@@ -430,6 +457,12 @@ func resourceComputeRouterUpdate(d *schema.ResourceData, meta interface{}) error
 	} else if v, ok := d.GetOkExists("bgp"); ok || !reflect.DeepEqual(v, bgpProp) {
 		obj["bgp"] = bgpProp
 	}
+	md5AuthenticationKeysProp, err := expandComputeRouterMd5AuthenticationKeys(d.Get("md5_authentication_keys"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("md5_authentication_keys"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, md5AuthenticationKeysProp)) {
+		obj["md5AuthenticationKeys"] = md5AuthenticationKeysProp
+	}
 
 	lockName, err := tpgresource.ReplaceVars(d, config, "router/{{region}}/{{name}}")
 	if err != nil {
@@ -824,6 +857,40 @@ func expandComputeRouterEncryptedInterconnectRouter(v interface{}, d tpgresource
 	return v, nil
 }
 
+func expandComputeRouterMd5AuthenticationKeys(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	l := v.([]interface{})
+	if len(l) == 0 || l[0] == nil {
+		return nil, nil
+	}
+	raw := l[0]
+	original := raw.(map[string]interface{})
+	transformed := make(map[string]interface{})
+
+	transformedName, err := expandComputeRouterMd5AuthenticationKeysName(original["name"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedName); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["name"] = transformedName
+	}
+
+	transformedKey, err := expandComputeRouterMd5AuthenticationKeysKey(original["key"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedKey); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["key"] = transformedKey
+	}
+
+	return transformed, nil
+}
+
+func expandComputeRouterMd5AuthenticationKeysName(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
+func expandComputeRouterMd5AuthenticationKeysKey(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandComputeRouterRegion(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	f, err := tpgresource.ParseGlobalFieldValue("regions", v.(string), "project", d, config, true)
 	if err != nil {

google/services/compute/resource_compute_router_generated_meta.yaml

@@ -15,6 +15,8 @@ fields:
   - field: 'creation_timestamp'
   - field: 'description'
   - field: 'encrypted_interconnect_router'
+  - field: 'md5_authentication_keys.key'
+  - field: 'md5_authentication_keys.name'
   - field: 'name'
   - field: 'network'
   - field: 'region'

google/services/compute/resource_compute_router_generated_test.go

@@ -49,7 +49,7 @@ func TestAccComputeRouter_routerBasicExample(t *testing.T) {
 				ResourceName:            "google_compute_router.foobar",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"advertisedIpRanges", "network", "region"},
+				ImportStateVerifyIgnore: []string{"advertisedIpRanges", "md5_authentication_keys", "network", "region"},
 			},
 		},
 	})
@@ -99,7 +99,7 @@ func TestAccComputeRouter_computeRouterEncryptedInterconnectExample(t *testing.T
 				ResourceName:            "google_compute_router.encrypted-interconnect-router",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"advertisedIpRanges", "network", "region"},
+				ImportStateVerifyIgnore: []string{"advertisedIpRanges", "md5_authentication_keys", "network", "region"},
 			},
 		},
 	})
@@ -123,6 +123,60 @@ resource "google_compute_network" "network" {
 `, context)
 }
 
+func TestAccComputeRouter_computeRouterMd5encryptedExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeRouterDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeRouter_computeRouterMd5encryptedExample(context),
+			},
+			{
+				ResourceName:            "google_compute_router.foobar",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"advertisedIpRanges", "md5_authentication_keys", "network", "region"},
+			},
+		},
+	})
+}
+
+func testAccComputeRouter_computeRouterMd5encryptedExample(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_compute_router" "foobar" {
+  name    = "tf-test-test-router%{random_suffix}"
+  network = google_compute_network.foobar.name
+  bgp {
+    asn               = 64514
+    advertise_mode    = "CUSTOM"
+    advertised_groups = ["ALL_SUBNETS"]
+    advertised_ip_ranges {
+      range = "1.2.3.4"
+    }
+    advertised_ip_ranges {
+      range = "6.7.0.0/16"
+    }
+  }
+  md5_authentication_keys {
+    name = "test"
+    key = "test"
+  }
+}
+
+resource "google_compute_network" "foobar" {
+  name                    = "tf-test-test-network%{random_suffix}"
+  auto_create_subnetworks = false
+}
+`, context)
+}
+
 func testAccCheckComputeRouterDestroyProducer(t *testing.T) func(s *terraform.State) error {
 	return func(s *terraform.State) error {
 		for name, rs := range s.RootModule().Resources {

website/docs/r/compute_router.html.markdown

@@ -120,6 +120,11 @@ The following arguments are supported:
   Indicates if a router is dedicated for use with encrypted VLAN
   attachments (interconnectAttachments).
 
+* `md5_authentication_keys` -
+  (Optional)
+  Keys used for MD5 authentication.
+  Structure is [documented below](#nested_md5_authentication_keys).
+
 * `region` -
   (Optional)
   Region where the router resides.
@@ -193,6 +198,17 @@ The following arguments are supported:
   (Optional)
   User-specified description for the IP range.
 
+<a name="nested_md5_authentication_keys"></a>The `md5_authentication_keys` block supports:
+
+* `name` -
+  (Required)
+  Name used to identify the key. Must be unique within a router.
+  Must be referenced by exactly one bgpPeer. Must comply with RFC1035.
+
+* `key` -
+  (Required)
+  Value of the key used for MD5 authentication.
+
 ## Attributes Reference
 
 In addition to the arguments listed above, the following computed attributes are exported: