Run relevant VCR tests in GA

[melinath]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment or link the pull request to this issue.

Currently it is possible for us to introduce crashing bugs like #13097 through innocuous-seeming changes like GoogleCloudPlatform/magic-modules#6824.

This caused GA-only test failures due to some missing changes, which were resolved in GoogleCloudPlatform/magic-modules#6860.

This kind of issue is not caught by our current tests, but it's very bad for our users and causes extra load on maintainers to fix. We should automate testing for it by running GA VCR tests on PRs for relevant tests.

[melinath]

may be blocked by project split

[rileykarson]

Related: #9148

[melinath]

#16661 would have been caught by this.

[melinath]

#17388 would have been caught by this (12 100% test failures)

[melinath]

GoogleCloudPlatform/magic-modules#9965 fixed an issue that could have been caught by this - patch behavior was not properly updated during a promotion.

[melinath]

#18091 and #18092 would have been caught by this. (7 100% failures)

[melinath]

#18239 would have been caught by this.

[melinath]

The following would have been caught by this:

• Failing test(s): TestAccComputeBackendService_withClientTlsPolicy #19068
• Failing test(s): TestAccComputeTargetHttpsProxy_update #19070
• Failing test(s): TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample #19075
• Failing test(s): TestAccKmsCryptoKey_keyAccessJustificationsPolicy #19083