Refactor tests to avoid subtests and improve test artifacts posted to PRs

[SarahFrench]

Background

Acceptance tests that use Cloud identity groups experience issues due to concurrent writes (see #10001)

Q: Can the acceptance tests be re-written to avoid using subtests? This will allow easier access to test logs in automated PR messages

What kind of contribution is this issue about?

acceptance test

Related PR(s), if any:

• Failing test(s): CloudIdentityGroup still exists #10001
• Run tests that use cloud_identity_group serially GoogleCloudPlatform/magic-modules#7322

Details

terraform-provider-google/google/services/cloudidentity/resource_cloud_identity_group_test.go

Lines 18 to 46 in 52d037c

	// Intended to fix https://github.com/hashicorp/terraform-provider-google/issues/10001
	// These are all of the tests that use a cloud_identity_group, except for
	// testAccAccessContextManagerGcpUserAccessBinding_basicTest. The theory is that they sometimes
	// fail with a 409 because of concurrent roster mutations, so running them serially should prevent
	// the error.
	func TestAccCloudIdentityGroup(t *testing.T) {
	testCases := map[string]func(t *testing.T){
	"basic": testAccCloudIdentityGroup_cloudIdentityGroupsBasicExampleTest,
	"update": testAccCloudIdentityGroup_updateTest,
	"membership_basic": testAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipExampleTest,
	"membership_update": testAccCloudIdentityGroupMembership_updateTest,
	"membership_import": testAccCloudIdentityGroupMembership_importTest,
	"membership_dne": testAccCloudIdentityGroupMembership_membershipDoesNotExistTest,
	"membership_user": testAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserExampleTest,
	"data_source_basic": testAccDataSourceCloudIdentityGroups_basicTest,
	"data_source_membership_basic": testAccDataSourceCloudIdentityGroupMemberships_basicTest,
	}
	for name, tc := range testCases {
	// shadow the tc variable into scope so that when
	// the loop continues, if t.Run hasn't executed tc(t)
	// yet, we don't have a race condition
	// see https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables
	tc := tc
	t.Run(name, func(t *testing.T) {
	tc(t)
	})
	}
	}

[melinath]

Now that we've split packages we could omit t.Parallel instead of using subtests.