`data "google_compute_image"` fails on destroy path if image doesn't exist

[mr0re1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Terraform Version & Provider Version(s)

Terraform v1.9.2
on linux_386

• provider registry.terraform.io/hashicorp/google v6.23.0
• provider registry.terraform.io/hashicorp/google-beta v6.23.0

Affected Resource(s)

google_compute_image

Terraform Configuration

data "google_compute_image" "slurm" {
  name    = "somename"
  project = "someproject"
}

Debug Output

No response

Expected Behavior

$ terraform destroy
...
# All good

Actual Behavior

$ terraform destroy
....
│ Error: error retrieving image information: googleapi: Error 404: The resource 'projects/hpc-toolkit-dev-staging/global/images/slurm-gcp-6-8-debian-11-1736357162' was not found, notFound
│
│   with module.debug_nodeset.data.google_compute_image.slurm,
│   on modules/embedded/community/modules/compute/schedmd-slurm-gcp-v6-nodeset/source_image_logic.tf line 42, in data "google_compute_image" "slurm":
│   42: data "google_compute_image" "slurm" {
│

Steps to reproduce

1. apply
2. remove image (not by terraform, but "manually")
3. destroy

Important Factoids

No response

References

b/401055259

[rohitramu]

Looks like there's precedent to just log a warning and continue if the resource was not found: hashicorp/terraform#3742

I guess this just needs to be implemented for "google_compute_image"?

[mjogdand]

@mr0re1 - It's default behavior of terraform, data source to return errors on 404s when applicable instead of silently failing for all data sources in v5.0.0

https://registry.terraform.io/providers/hashicorp/google/latest/docs/guides/version_5_upgrade#datasources-now-error-universally-on-404

This issue can be fixed by explicitly adding -refresh=false for destroy will also avoid destroy error when the inline data source is not found

for more details please refer this PR - GoogleCloudPlatform/magic-modules#13308

[ggtisc]

Hi @mr0re1 !

Is this a custom image which you are trying to destroy? or a pre-existing template image like the following example?

data "google_compute_image" "debian" {
  family  = "debian-12"
  project = "debian-cloud"
}