Address PR feedback and add missing field

Author: rodrigo-hcp

docs/resources/vault_secrets_app.md

@@ -29,7 +29,7 @@ resource "hcp_vault_secrets_app" "example" {
 
 - `description` (String) The Vault Secrets app description
 - `project_id` (String) The ID of the HCP project where the HCP Vault Secrets app is located.
-- `sync_names` (List of String) List of sync names to associate with this app.
+- `sync_names` (Set of String) Set of sync names to associate with this app.
 
 ### Read-Only
 

docs/resources/vault_secrets_sync.md

@@ -42,8 +42,12 @@ resource "hcp_vault_secrets_sync" "example_aws_sync" {
 
 Required:
 
-- `project_id` (String, Sensitive)
-- `scope` (String)
+- `scope` (String) The scope to which values apply. The valid options are GROUP and PROJECT
+
+Optional:
+
+- `group_id` (String, Sensitive) ID of the group, if the scope is GROUP
+- `project_id` (String, Sensitive) ID of the project, if the scope is PROJECT
 
 ## Import
 

internal/provider/vaultsecrets/resource_vault_secrets_app.go

@@ -10,14 +10,14 @@ import (
 
 	"github.com/hashicorp/hcp-sdk-go/clients/cloud-vault-secrets/stable/2023-11-28/client/secret_service"
 	secretmodels "github.com/hashicorp/hcp-sdk-go/clients/cloud-vault-secrets/stable/2023-11-28/models"
-	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
+	"github.com/hashicorp/terraform-plugin-framework-validators/setvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/listplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/setplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 	"github.com/hashicorp/terraform-plugin-framework/types"
@@ -93,15 +93,17 @@ func (r *resourceVaultSecretsApp) Schema(_ context.Context, _ resource.SchemaReq
 				Computed:    true,
 				Description: "The app's resource name in the format secrets/project/<project ID>/app/<app Name>.",
 			},
-			"sync_names": schema.ListAttribute{
-				Description: "List of sync names to associate with this app.",
+			"sync_names": schema.SetAttribute{
+				Description: "Set of sync names to associate with this app.",
 				Optional:    true,
 				ElementType: types.StringType,
-				PlanModifiers: []planmodifier.List{
-					listplanmodifier.RequiresReplace(),
+				PlanModifiers: []planmodifier.Set{
+					setplanmodifier.RequiresReplace(),
 				},
-				Validators: []validator.List{
-					listvalidator.UniqueValues(),
+				Validators: []validator.Set{
+					setvalidator.ValueStringsAre(
+						stringvalidator.LengthBetween(1, 511),
+					),
 				},
 			}},
 	}

internal/provider/vaultsecrets/resource_vault_secrets_sync.go

@@ -134,13 +134,18 @@ func (r *resourceVaultSecretsSync) Schema(_ context.Context, _ resource.SchemaRe
 			Optional:    true,
 			Attributes: map[string]schema.Attribute{
 				"scope": schema.StringAttribute{
-					Description: "", // TODO: write this description
+					Description: "The scope to which values apply. The valid options are GROUP and PROJECT",
 					Required:    true,
 				},
+				"group_id": schema.StringAttribute{
+					Description: "ID of the group, if the scope is GROUP",
+					Sensitive:   true,
+					Optional:    true,
+				},
 				"project_id": schema.StringAttribute{
-					Description: "", // TODO: write this description
-					Required:    true,
+					Description: "ID of the project, if the scope is PROJECT",
 					Sensitive:   true,
+					Optional:    true,
 				},
 			},
 			Validators: []validator.Object{

internal/provider/vaultsecrets/resource_vault_secrets_sync_test.go

@@ -21,18 +21,18 @@ func TestAccVaultSecretsResourceSync(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttrSet("hcp_vault_secrets_integration.acc_test", "organization_id"),
 					resource.TestCheckResourceAttr("hcp_vault_secrets_integration.acc_test", "project_id", os.Getenv("HCP_PROJECT_ID")),
-					resource.TestCheckResourceAttr("hcp_vault_secrets_sync.acc_test_aws", "name", syncName),
-					resource.TestCheckResourceAttr("hcp_vault_secrets_sync.acc_test_aws", "integration_name", integrationName),
-					resource.TestCheckResourceAttrSet("hcp_vault_secrets_sync.acc_test_aws", "organization_id"),
-					resource.TestCheckResourceAttrSet("hcp_vault_secrets_sync.acc_test_aws", "project_id")),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_syhcp_vault_secrets_syncnc.acc_test_gitlab", "name", syncName),
+					resource.TestCheckResourceAttr("hcp_vault_secrets_sync.acc_test_gitlab", "integration_name", integrationName),
+					resource.TestCheckResourceAttrSet("hcp_vault_secrets_sync.acc_test_gitlab", "organization_id"),
+					resource.TestCheckResourceAttrSet("hcp_vault_secrets_sync.acc_test_gitlab", "project_id")),
 			},
 		},
 	})
 }
 
 func syncConfig(syncName, integrationName string) string {
 	return fmt.Sprintf(`
-	resource "hcp_vault_secrets_sync" "acc_test_aws" {
+	resource "hcp_vault_secrets_sync" "acc_test_gitlab" {
 	  name = %q
 	  integration_name = %q
 	}`, syncName, integrationName)