Linter

Author: ncabatoff

internal/clients/iampolicy/resource_iam_binding.go

@@ -104,7 +104,7 @@ func (r *resourceBinding) Schema(_ context.Context, _ resource.SchemaRequest, re
 		Attributes:          r.parentSchema.Attributes,
 	}
 
-	if resp.Schema.Attributes == nil || len(resp.Schema.Attributes) == 0 {
+	if len(resp.Schema.Attributes) == 0 {
 		resp.Schema.Attributes = baseBindingSchema
 	} else {
 		for k, v := range baseBindingSchema {

internal/clients/iampolicy/resource_iam_policy.go

@@ -111,7 +111,7 @@ func (r *resourcePolicy) Schema(_ context.Context, _ resource.SchemaRequest, res
 		Attributes:          r.parentSchema.Attributes,
 	}
 
-	if resp.Schema.Attributes == nil || len(resp.Schema.Attributes) == 0 {
+	if len(resp.Schema.Attributes) == 0 {
 		resp.Schema.Attributes = basePolicySchema
 	} else {
 		for k, v := range basePolicySchema {

internal/provider/packer/testutils/testclient/operation.go

@@ -4,6 +4,7 @@
 package testclient
 
 import (
+	"errors"
 	"fmt"
 	"testing"
 	"time"
@@ -45,10 +46,10 @@ func WaitForOperation(
 		switch *resp.Payload.Operation.State {
 		case sharedmodels.HashicorpCloudOperationOperationStatePENDING:
 			msg := fmt.Sprintf("==> Operation \"%s\" pending...", operationName)
-			return fmt.Errorf(msg)
+			return errors.New(msg)
 		case sharedmodels.HashicorpCloudOperationOperationStateRUNNING:
 			msg := fmt.Sprintf("==> Operation \"%s\" running...", operationName)
-			return fmt.Errorf(msg)
+			return errors.New(msg)
 		case sharedmodels.HashicorpCloudOperationOperationStateDONE:
 		default:
 			t.Errorf("Operation returned unknown state: %s", *resp.Payload.Operation.State)

internal/providersdkv2/test_helpers_for_packer_test.go

@@ -4,6 +4,7 @@
 package providersdkv2
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"testing"
@@ -110,10 +111,10 @@ func waitForOperation(
 		switch *resp.Payload.Operation.State {
 		case sharedmodels.HashicorpCloudOperationOperationStatePENDING:
 			msg := fmt.Sprintf("==> Operation \"%s\" pending...", operationName)
-			return fmt.Errorf(msg)
+			return errors.New(msg)
 		case sharedmodels.HashicorpCloudOperationOperationStateRUNNING:
 			msg := fmt.Sprintf("==> Operation \"%s\" running...", operationName)
-			return fmt.Errorf(msg)
+			return errors.New(msg)
 		case sharedmodels.HashicorpCloudOperationOperationStateDONE:
 		default:
 			t.Errorf("Operation returned unknown state: %s", *resp.Payload.Operation.State)