add import to random_pet resource #184

[wakeful]

No description provided.

[MikaelFerland]

@bendbennett, do you know if anyone that may help with that ?

[wakeful]

gosh.. I forgot about this MR,
I will rebase & port my fix to work with latest main later today.

[wakeful]

I ported my change to the latest version of main
one improvement over the previous version - import now supports adding a custom prefix and separator

@MikaelFerland can you check by building from my branch? if the change works for you? is anything missing?

[MikaelFerland]

@wakeful I could try, but after I will not able to do anything. I'm not working for HashiCorp.
@bendbennett do we have to do anything else to have it reviewed ?

[mjperrone]

I'd like this merged

[bendbennett]

Hi @wakeful, @MikaelFerland, @mjperrone 👋

Thank you for submitting the PR @wakeful and apologies in the delay in us getting to it.

Your proposal is an interesting one, as you're essentially overloading the import id with additional attributes/fields for use in populating the resource during import. There are a number of use cases described for this scenario.

At this time, we are intending to implement Import via Configuration for providers developed with the Framework to deliver the ability to import multiple attributes/fields. We would therefore like to hold off and avoid "overloading" the import id until Import via Configuration becomes available.

[wakeful]

hi @bendbennett that's an interesting proposal, it would simplify a lot!

my change came from a migration project that I'm currently working on,
but I don't mind running a custom provider build.

let's park this change till you guys implement import via configuration.

[jhyelton]

Any update to this issue now that import via configuration has been implemented?

[wakeful]

hey @jhyelton

TBH I forgot already about this PR 🤦‍♂️
added to ToDo for this week to do a rebase and check what's needed :)

[wakeful]

hey @bendbennett any chance we could try to merge this? (not sure if you are still the maintainer).

[mjperrone]

@bflad @austinvalle