Make SoftLayer provider's timeouts configurable

[hashibot]

This issue was originally opened by @bondyk as hashicorp/terraform#9113. It was migrated here as part of the provider split. The original body of the issue is below.

---

Hi,

Terraform doesn't have a possibility to configure timeout for SoftLayer provider. In case if SoftLayer takes more than 10 minutes to create a new virtual guest than terraform exits with timeout error.
It would be great to be able to configure timeout values.
Currently timeout values are hard coded here: https://github.com/hashicorp/terraform/blob/master/builtin/providers/softlayer/resource_softlayer_virtual_guest.go (WaitForUpgradeTransactionsToAppear, WaitForPublicIpAvailable, WaitForNoActiveTransactions)

Terraform Version

Terraform v0.7.4

Affected Resource(s)

• softlayer_virtual_guest

Debug Output

softlayer_virtual_guest.tor01-dev-ybt-vm-3178-sa: Still creating... (9m50s elapsed)
softlayer_virtual_guest.tor01-dev-ybt-vm-3178-sa: Still creating... (10m0s elapsed)
Error applying plan:

1 error(s) occurred:

softlayer_virtual_guest.tor01-dev-ybt-vm-3178-sa: Error waiting for virtual machine (24570963) to become ready: timeout while waiting for state to become 'idle' (last state: 'active', timeout: 10m0s)

Expected Behavior

It should be possible to configure timeouts for SoftLayer provider:

• to wait for no active transactions
• to wait for public IP available
• to wait for upgrade transactions to appear

Actual Behavior

Terraform exits with timeout error if time for waiting active transactions takes more than 10 minutes

Steps to Reproduce

Use SoftLayer provider to create a new virtual guest

References

• The same related to OpenStack Question: Configurable timeout for terraform apply on OpenStack terraform#4129

[albee-jhoney]

The corresponding resource in the IBM Cloud provider: https://github.com/IBM-Cloud/terraform-provider-ibm is ibm_compute_vm_instance. And, it supports wait_time_minutes; refer to the documentation here: https://ibm-cloud.github.io/tf-ibm-docs/v0.8.0/r/compute_vm_instance.html