Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow formatting of .tfbackend files #36725

Closed

Conversation

lucioreisgh
Copy link

@lucioreisgh lucioreisgh commented Mar 20, 2025

This Pull Request enhances the terraform fmt command by enabling support for .tfbackend files. Additionally, it improves error logging by including previously unsupported file extensions.

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Copy link

hashicorp-cla-app bot commented Mar 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Signed-off-by: Lucio Reis <[email protected]>
@lucioreisgh lucioreisgh marked this pull request as ready for review March 20, 2025 02:57
@lucioreisgh lucioreisgh requested a review from a team as a code owner March 20, 2025 02:57
@lucioreisgh
Copy link
Author

lucioreisgh commented Mar 20, 2025

@crw Im starting to contribute now to Terraform, this PR is for this issue #36564

Anything else I should do?

@crw
Copy link
Contributor

crw commented Mar 20, 2025

Hi @lucioreisgh. The first thing you should do is read the Contributing Guide. Generally we request that the design of a change be discussed in the relevant issue before implementation if you want it to be reviewed.

In this case, given the conversation on #36570, I am going to close this PR, as it does not change or further address the problems discussed in that thread.

@crw crw closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants