Skip to content

feat: allow dynamic kerberos lease TTL [Issue #45]#113

Open
r-ushil wants to merge 3 commits intohashicorp:mainfrom
r-ushil:main
Open

feat: allow dynamic kerberos lease TTL [Issue #45]#113
r-ushil wants to merge 3 commits intohashicorp:mainfrom
r-ushil:main

Conversation

@r-ushil
Copy link

@r-ushil r-ushil commented Feb 12, 2025

fixes #45

@r-ushil r-ushil requested a review from a team as a code owner February 12, 2025 18:00
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Feb 12, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@r-ushil-gsa
Copy link

Just wanted to bump this, as it's been waiting for review for a while, passes the tests and doesn't seem too intrusive of a change! @hc-github-team-secure-vault-ecosystem

Thanks again!

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r-ushil Hello, thanks for the PR! Do you mind adding some tests?

@r-ushil
Copy link
Author

r-ushil commented Dec 9, 2025

should be done. @fairclothjm

bats /home/rushil/vault-plugin-auth-kerberos/test/acceptance/server-enterprise-basic-tests.bats
server-enterprise-basic-tests.bats
 ✓ auth/kerberos: create namespace
 ✓ auth/kerberos: register plugin
 ✓ auth/kerberos: enable and configure auth method
 ✓ auth/kerberos: setup and authentication within a Vault namespace
 ✓ auth/kerberos: dynamic TTL feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass through custom ttl

3 participants