Fix VSS double reconciliation issue and prevent WebSocket teardown/reconnect. (#1278)

Author: Balaji2198

controllers/vaultstaticsecret_controller.go

@@ -285,6 +285,11 @@ func (r *VaultStaticSecretReconciler) Reconcile(ctx context.Context, req ctrl.Re
 		logger.V(consts.LogLevelDebug).Info("Secret sync not required")
 	}
 
+	o.Status.LastGeneration = o.GetGeneration()
+	if err := r.updateStatus(ctx, o, true, conditions...); err != nil {
+		return ctrl.Result{}, err
+	}
+
 	if o.Spec.SyncConfig != nil && o.Spec.SyncConfig.InstantUpdates {
 		logger.V(consts.LogLevelDebug).Info("Event watcher enabled")
 		// ensure event watcher is running
@@ -296,11 +301,6 @@ func (r *VaultStaticSecretReconciler) Reconcile(ctx context.Context, req ctrl.Re
 		r.unWatchEvents(o, c)
 	}
 
-	o.Status.LastGeneration = o.GetGeneration()
-	if err := r.updateStatus(ctx, o, true, conditions...); err != nil {
-		return ctrl.Result{}, err
-	}
-
 	return ctrl.Result{
 		RequeueAfter: requeueAfter,
 	}, nil