Skip to content

Commit 935c9a7

Browse files
hashrocketeervnegrisoloGabriel Reis
committed
Bump wallaby dep
Co-authored-by: Vinicius Negrisolo <vinicius.negrisolo@hashrocket.com> Co-authored-by: Gabriel Reis <gabriel.reis@hashrocket.com>
1 parent 965f801 commit 935c9a7

19 files changed

Lines changed: 84 additions & 88 deletions

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ defmodule Tilex.Mixfile do
6767
{:tzdata, "~> 1.1.0"},
6868
{:ueberauth_google, "~> 0.5"},
6969
{:usage_rules, "~> 0.1", only: [:dev]},
70-
{:wallaby, "~>0.30.1", [runtime: false, only: :test]}
70+
{:wallaby, "~>0.30.1", runtime: false, only: :test}
7171
]
7272
end
7373

mix.lock

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

test/features/admin_edits_post_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
defmodule AdminEditsPostTest do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

44
alias Tilex.Integration.Pages.PostForm
55
alias Tilex.Integration.Pages.PostShowPage
66

7-
test "fills out form and updates post from post show", %{session: session} do
7+
feature "fills out form and updates post from post show", %{session: session} do
88
Factory.insert!(:channel, name: "phoenix")
99
developer = Factory.insert!(:developer, %{username: "luke-skywalker"})
1010
admin = Factory.insert!(:developer, %{admin: true, username: "darth-vader"})
@@ -29,7 +29,7 @@ defmodule AdminEditsPostTest do
2929
|> PostShowPage.ensure_page_loaded("Even Awesomer Post!")
3030
end
3131

32-
test "enters a title that is too long", %{session: session} do
32+
feature "enters a title that is too long", %{session: session} do
3333
Factory.insert!(:channel, name: "phoenix")
3434
developer = Factory.insert!(:developer)
3535

test/features/developer_creates_post_test.exs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ defmodule DeveloperCreatesPostTest do
77
alias Tilex.Integration.Pages.PostShowPage
88
alias Tilex.Integration.Pages.PostForm
99

10-
test "fills out form and save", %{session: session} do
11-
Ecto.Adapters.SQL.Sandbox.allow(Tilex.Repo, self(), Process.whereis(Tilex.Notifications))
10+
feature "fills out form and save", %{session: session} do
1211
Factory.insert!(:channel, name: "phoenix")
1312
developer = Factory.insert!(:developer)
1413

@@ -48,8 +47,7 @@ defmodule DeveloperCreatesPostTest do
4847
|> Navigation.ensure_heading("TODAY I LEARNED")
4948
end
5049

51-
test "fills out form and save & publish", %{session: session} do
52-
Ecto.Adapters.SQL.Sandbox.allow(Tilex.Repo, self(), Process.whereis(Tilex.Notifications))
50+
feature "fills out form and save & publish", %{session: session} do
5351
Factory.insert!(:channel, name: "phoenix")
5452
developer = Factory.insert!(:developer)
5553

@@ -88,7 +86,7 @@ defmodule DeveloperCreatesPostTest do
8886
|> Navigation.ensure_heading("TODAY I LEARNED")
8987
end
9088

91-
test "cancels submission", %{session: session} do
89+
feature "cancels submission", %{session: session} do
9290
developer = Factory.insert!(:developer)
9391

9492
session
@@ -99,7 +97,7 @@ defmodule DeveloperCreatesPostTest do
9997
|> IndexPage.ensure_page_loaded()
10098
end
10199

102-
test "fails to enter things", %{session: session} do
100+
feature "fails to enter things", %{session: session} do
103101
developer = Factory.insert!(:developer)
104102

105103
session
@@ -113,7 +111,7 @@ defmodule DeveloperCreatesPostTest do
113111
|> CreatePostPage.expect_form_has_error("Channel can't be blank")
114112
end
115113

116-
test "enters a title that is too long", %{session: session} do
114+
feature "enters a title that is too long", %{session: session} do
117115
Factory.insert!(:channel, name: "phoenix")
118116
developer = Factory.insert!(:developer)
119117

@@ -131,7 +129,7 @@ defmodule DeveloperCreatesPostTest do
131129
|> CreatePostPage.expect_form_has_error("Title should be at most 50 character(s)")
132130
end
133131

134-
test "enters a body that is too long", %{session: session} do
132+
feature "enters a body that is too long", %{session: session} do
135133
Factory.insert!(:channel, name: "phoenix")
136134
developer = Factory.insert!(:developer)
137135

@@ -149,7 +147,7 @@ defmodule DeveloperCreatesPostTest do
149147
|> CreatePostPage.expect_form_has_error("Body should be at most 200 word(s)")
150148
end
151149

152-
test "enters markdown code into the body", %{session: session} do
150+
feature "enters markdown code into the body", %{session: session} do
153151
Factory.insert!(:channel, name: "phoenix")
154152
developer = Factory.insert!(:developer)
155153

@@ -166,7 +164,7 @@ defmodule DeveloperCreatesPostTest do
166164
assert find(session, Query.css("strong", text: "bold powerup"))
167165
end
168166

169-
test "views parsed markdown preview", %{session: session} do
167+
feature "views parsed markdown preview", %{session: session} do
170168
Factory.insert!(:channel, name: "phoenix")
171169
developer = Factory.insert!(:developer)
172170

test/features/developer_edits_post_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
defmodule DeveloperEditsPostTest do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

44
alias Tilex.Integration.Pages.PostForm
55
alias Tilex.Integration.Pages.PostShowPage
66

7-
test "fills out form and updates post from post show", %{session: session} do
7+
feature "fills out form and updates post from post show", %{session: session} do
88
Factory.insert!(:channel, name: "phoenix")
99
developer = Factory.insert!(:developer)
1010

test/features/developer_edits_profile_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
defmodule DeveloperEditsProfileTest do
22
use Tilex.IntegrationCase, async: false
33

4-
test "fills out form and updates post from post show", %{session: session} do
4+
feature "fills out form and updates post from post show", %{session: session} do
55
developer = Factory.insert!(:developer, email: "fine@sixdollareggs.com")
66

77
sign_in(session, developer)

test/features/developer_sees_navigation_bar_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
defmodule DeveloperSeesNavigationBarTest do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

44
alias Tilex.Integration.Pages.Navigation
55

66
describe "when developer is not authenticated" do
7-
test "there is no link on admin navbar", %{session: session} do
7+
feature "there is no link on admin navbar", %{session: session} do
88
link_texts =
99
session
1010
|> visit("/")
@@ -17,7 +17,7 @@ defmodule DeveloperSeesNavigationBarTest do
1717
describe "when developer is authenticated" do
1818
setup [:authenticated_developer]
1919

20-
test "there are links on admin navbar", %{session: session} do
20+
feature "there are links on admin navbar", %{session: session} do
2121
link_texts =
2222
session
2323
|> visit("/")

test/features/developer_signs_out_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
defmodule Features.DeveloperSignsOutTest do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

4-
test "signs out and sees a flash message", %{:session => session} do
4+
feature "signs out and sees a flash message", %{:session => session} do
55
developer = Factory.insert!(:developer)
66

77
session

test/features/developer_views_stats_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
defmodule Features.DeveloperViewsStatsTest do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

44
def format_stats_date(%Date{year: year, day: day, month: month}) do
55
day_s = String.pad_leading(Integer.to_string(day), 2, "0")
@@ -8,7 +8,7 @@ defmodule Features.DeveloperViewsStatsTest do
88
"#{month_s}-#{day_s}-#{year}"
99
end
1010

11-
test "sees total number of posts by channel", %{session: session} do
11+
feature "sees total number of posts by channel", %{session: session} do
1212
developer = Factory.insert!(:developer)
1313
phoenix_channel = Factory.insert!(:channel, name: "phoenix")
1414
other_channel = Factory.insert!(:channel, name: "other")
@@ -70,7 +70,7 @@ defmodule Features.DeveloperViewsStatsTest do
7070
assert text_without_newlines(other_channel) =~ "#other 3 posts"
7171
end
7272

73-
test "does not see sees til activity chart", %{session: session} do
73+
feature "does not see sees til activity chart", %{session: session} do
7474
developer = Factory.insert!(:developer)
7575

7676
session

test/features/robot_sees_sitemap.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
defmodule RobotSeesSitemap do
2-
use Tilex.IntegrationCase, async: true
2+
use Tilex.IntegrationCase, async: false
33

4-
test "And sees posts", %{session: session} do
4+
feature "And sees posts", %{session: session} do
55
post = Factory.insert!(:post, title: "Klaus and Greta")
66

77
visit(session, "/sitemap.xml")

0 commit comments

Comments
 (0)