Merge pull request #1595 from hashtopolis/1593-bug-taskwrappers-weird-state-when-tasks-have-been-deleted

1593 bug taskwrappers weird state when tasks have been deleted

Author: gpascal123

src/inc/apiv2/common/AbstractModelAPI.class.php

@@ -1526,6 +1526,9 @@ protected function updateToManyRelationship(Request $request, array $data, array
     if ($relationKey == null) {
       throw new HttpError("Relation does not exist!");
     }
+    if ($relation["readonly"] === true) {
+      throw new HttpError("This relationship is readonly");
+    }
 
     $relationType = $relation['relationType'];
     $features = $this->getFeaturesOther($relationType);
@@ -1593,7 +1596,10 @@ public function postToManyRelationshipLink(Request $request, Response $response,
     $relation = $this->getToManyRelationships()[$args['relation']];
     $relationKey = $relation['relationKey'];
     if ($relationKey == null) {
-      throw new HttpError("Relation does not exist!");
+      throw new HttpError('Relation does not exist!');
+    }
+    if ($relation['readonly'] === true) {
+      throw new HttpError('This relationship is readonly');
     }
 
     // check if the object queried exists

src/inc/apiv2/model/taskwrappers.routes.php

@@ -92,6 +92,7 @@ public static function getToManyRelationships(): array {
 
         'relationType' => Task::class,
         'relationKey' => Task::TASK_WRAPPER_ID,
+        'readonly' => true // Not allowed to change tasks of a taskwrapper 
       ],
     ];
   }

src/inc/utils/TaskUtils.class.php

@@ -1140,6 +1140,11 @@ public static function deleteTask($task) {
     $qF = new QueryFilter(Chunk::TASK_ID, $task->getId(), "=");
     Factory::getChunkFactory()->massDeletion([Factory::FILTER => $qF]);
     Factory::getTaskFactory()->delete($task);
+    $taskWrapper = Factory::getTaskWrapperFactory()->get($task->getTaskWrapperId());
+    // If last task of taskwrapper has been deleted, delete taskwrapper aswell
+    if (count(self::getTasksOfWrapper($taskWrapper->getId())) === 0) {
+      Factory::getTaskWrapperFactory()->delete($taskWrapper);
+    }
     LockUtils::deleteLockFile($task->getId());
   }