fix: add in extra salt check

james-iwc · james-iwc · commit a308cc3add93 · 2024-10-31T14:46:58.000-06:00
diff --git a/src/inc/utils/HashlistUtils.class.php b/src/inc/utils/HashlistUtils.class.php
@@ -1144,7 +1144,9 @@ public static function getCrackedHashes($hashlistId, $user) {
         "crackpos" => $entry->getCrackPos()
       ];
       if ($hashlist->getIsSalted()) {
-        $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();
+        if (strlen($entry->getSalt()) > 0) {
+          $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();
+        }
       }
       $hashes[] = $arr;
     }

Original file line number	Diff line number	Diff line change
`@@ -1144,7 +1144,9 @@ public static function getCrackedHashes($hashlistId, $user) {`
`1144`	`1144`	`"crackpos" => $entry->getCrackPos()`
`1145`	`1145`	`];`
`1146`	`1146`	`if ($hashlist->getIsSalted()) {`
`1147`		`- $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();`
	`1147`	`+ if (strlen($entry->getSalt()) > 0) {`
	`1148`	`+ $arr["hash"] .= $hashlist->getSaltSeparator() . $entry->getSalt();`
	`1149`	`+ }`
`1148`	`1150`	`}`
`1149`	`1151`	`$hashes[] = $arr;`
`1150`	`1152`	`}`