Fixed code review

Author: jessevz

src/api/v2/index.php

@@ -306,6 +306,7 @@ public static function addCORSheaders(Request $request, $response) {
 require __DIR__ . "/../../inc/apiv2/helper/exportWordlist.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/getAccessGroups.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/getAgentBinary.routes.php";
+require __DIR__ . "/../../inc/apiv2/helper/getCracksOfTask.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/getFile.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/getUserPermission.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/importCrackedHashes.routes.php";
@@ -317,6 +318,5 @@ public static function addCORSheaders(Request $request, $response) {
 require __DIR__ . "/../../inc/apiv2/helper/setUserPassword.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/taskExtraDetails.routes.php";
 require __DIR__ . "/../../inc/apiv2/helper/unassignAgent.routes.php";
-require __DIR__ . "/../../inc/apiv2/helper/getCracksOfTask.routes.php";
 
 $app->run();

src/inc/apiv2/helper/getCracksOfTask.routes.php

@@ -7,13 +7,14 @@
 use Psr\Http\Message\ServerRequestInterface as Request;
 use DBA\Factory;
 use DBA\Hash;
+use DBA\Hashlist;
 use DBA\QueryFilter;
 use DBA\Task;
 use Middlewares\Utils\HttpErrorException;
 
 require_once(dirname(__FILE__) . "/../common/AbstractHelperAPI.class.php");
 
-class getCracksOfTaskHelper extends AbstractHelperAPI {
+class GetCracksOfTaskHelper extends AbstractHelperAPI {
   public static function getBaseUri(): string {
     return "/api/v2/helper/getCracksOfTask";
   }
@@ -23,7 +24,7 @@ public static function getAvailableMethods(): array {
   }
 
   public function getRequiredPermissions(string $method): array {
-    return [Hash::PERM_READ, Task::PERM_READ];
+    return [Hashlist::PERM_READ, Hash::PERM_READ, Task::PERM_READ];
   }
 
   public static function getResponse(): null {
@@ -63,7 +64,7 @@ public function getParamsSwagger(): array {
    */
   public function handleGet(Request $request, Response $response): Response {
     $this->preCommon($request);
-    $task = Factory::getTaskFactory()->get($_GET['task']);
+    $task = Factory::getTaskFactory()->get($request->getQueryParams()['task']);
     if ($task == null) {
       throw new HttpError("No task has been found with provided task id");
     }
@@ -98,7 +99,7 @@ public function handleGet(Request $request, Response $response): Response {
   }
 
   static public function register($app): void {
-    $baseUri = getCracksOfTaskHelper::getBaseUri();
+    $baseUri = GetCracksOfTaskHelper::getBaseUri();
 
     /* Allow CORS preflight requests */
     $app->options($baseUri, function (Request $request, Response $response): Response {
@@ -108,4 +109,4 @@ static public function register($app): void {
   }
 }
 
-getCracksOfTaskHelper::register($app);
+GetCracksOfTaskHelper::register($app);