Skip to content

Conversation

@s3inlc
Copy link
Member

@s3inlc s3inlc commented Sep 1, 2025

Changing the version comparison to a sophisticated library will avoid issues we have with some semantic version comparisons (e.g. beta -> beta2)

Smaller changes:

  • fixed Dockerfile casing
  • fixed missing .htaccess placed in install directory (when using docker)

@s3inlc s3inlc requested a review from Copilot September 1, 2025 12:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request replaces the custom version comparison functions with the standardized Composer Semver library for improved version handling across the application. The change introduces proper semantic version comparison capabilities and removes the custom implementation.

  • Replaced Util::versionComparison() calls with Composer\Semver\Comparator methods
  • Added Composer Semver dependency to the project
  • Removed the custom versionComparison method from the Util class

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
composer.json Added composer/semver dependency
src/inc/load.php Added vendor autoload requirement
src/inc/Util.class.php Removed custom version comparison method and updated binary comparison
Multiple update files Replaced Util::versionComparison with Comparator::lessThan
Multiple utility classes Updated version comparison calls to use Semver library
Dockerfile Minor formatting improvements with AS keyword capitalization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@s3inlc s3inlc requested a review from jessevz September 1, 2025 14:42
@s3inlc s3inlc merged commit c5fd68f into dev Sep 1, 2025
2 checks passed
@s3inlc s3inlc deleted the enhancement/version-comparison branch September 1, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants