-
Notifications
You must be signed in to change notification settings - Fork 245
replaced version comparison function with composer/semvar #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request replaces the custom version comparison functions with the standardized Composer Semver library for improved version handling across the application. The change introduces proper semantic version comparison capabilities and removes the custom implementation.
- Replaced
Util::versionComparison()calls withComposer\Semver\Comparatormethods - Added Composer Semver dependency to the project
- Removed the custom
versionComparisonmethod from the Util class
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Added composer/semver dependency |
| src/inc/load.php | Added vendor autoload requirement |
| src/inc/Util.class.php | Removed custom version comparison method and updated binary comparison |
| Multiple update files | Replaced Util::versionComparison with Comparator::lessThan |
| Multiple utility classes | Updated version comparison calls to use Semver library |
| Dockerfile | Minor formatting improvements with AS keyword capitalization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… happened later anyway)
…he devcontainer docker-compose file) to before checking for connection
Changing the version comparison to a sophisticated library will avoid issues we have with some semantic version comparisons (e.g. beta -> beta2)
Smaller changes: