Added more task validation in backend #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to handle cases where TaskWrapper objects may not have associated Task objects, improving robustness of the backend task management system.
Key changes:
- Added null checks for task objects retrieved from TaskWrapper queries
- Implemented error handling for invalid TaskWrapper states in priority updates and deletion operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TaskwrapperUtils.class.php | Added null check and exception throwing for invalid TaskWrapper in priority update method |
| taskwrappers.routes.php | Added conditional logic to handle TaskWrapper deletion when no associated Task exists |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $joined = Factory::getTaskFactory()->filter([Factory::FILTER => $qF, Factory::JOIN => $jF]); | ||
| $task = $joined[Factory::getTaskFactory()->getModelName()][0]; | ||
| if ($task === null) { | ||
| throw new HttpError("Invallid task, Taskwrapper does not have a task"); |
There was a problem hiding this comment.
There is a spelling error in the error message. 'Invallid' should be 'Invalid'.
Suggested change
| throw new HttpError("Invallid task, Taskwrapper does not have a task"); | |
| throw new HttpError("Invalid task, Taskwrapper does not have a task"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.