Skip to content

Conversation

@Eric-Wasson
Copy link

After this has been reviewed and before releasing I would suggest to do two steps:

  • Include a hint in the release notes to give a heads up about the new .env variable, so users can add their frontend there after upgrading and don't run into CORS errors.
  • Change the default warning in the frontend ("Network error. Please verify the IP address (localhost:8080) and try again. Note: APIv2 HASHTOPOLIS_APIV2_ENABLE=1 needs to be enabled. ") to include a hint about the CORS setting (e.g. "Please make sure to include the used frontend in the .env file.").

Note: because multiple values in the Allow-Origin header aren't allowed, a small workaround for getting the currently used frontend has been used (1 2)

@Eric-Wasson Eric-Wasson marked this pull request as ready for review November 12, 2025 12:10
@Eric-Wasson Eric-Wasson merged commit 6cb425c into dev Nov 27, 2025
2 checks passed
@s3inlc s3inlc deleted the 1265-properly-implement-cors branch November 28, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants