Added active chunk as data to agent #1736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the API to support dynamic resource inclusion through the aggregateData() method and introduces functionality for agents to include active chunk data in their responses.
Key Changes:
- Extended
aggregateData()signature to accept a reference parameter$includedDatafor dynamically adding related resources - Implemented
aggregateData()for agents to include active chunk information - Refactored duplicate code for processing resource expansions into a new
processExpands()method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/inc/apiv2/common/AbstractBaseAPI.class.php | Updated aggregateData() and obj2Resource() signatures to support dynamic includes; moved addToRelatedResources() from AbstractModelAPI; added new processExpands() method to consolidate expansion logic |
| src/inc/apiv2/common/AbstractModelAPI.class.php | Removed duplicate addToRelatedResources() method and refactored to use new processExpands() method |
| src/inc/apiv2/model/tasks.routes.php | Updated aggregateData() signature to match base class changes |
| src/inc/apiv2/model/agents.routes.php | Added aggregateData() implementation to fetch and include active chunk data for agents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gluafamichl
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.