tests: fix tests and add documentation

Author: Neunerlei

app/Http/Controllers/RoomController.php

@@ -5,7 +5,6 @@
 use App\Models\Attachment;
 use App\Models\Message;
 use App\Models\User;
-use App\Services\Api\ApiRequestMigrator;
 use App\Services\Chat\Message\MessageContentValidator;
 use App\Services\Chat\Room\RoomService;
 use App\Services\Storage\FileStorageService;
@@ -158,10 +157,8 @@ public function searchUser(Request $request): JsonResponse
 
 
     // SECTION: MESSAGE
-    public function sendMessage(Request $request, $slug, MessageContentValidator $contentValidator, ApiRequestMigrator $requestMigrator): JsonResponse
+    public function sendMessage(Request $request, $slug, MessageContentValidator $contentValidator): JsonResponse
     {
-
-        $request = $requestMigrator->migrate($request);
         $validatedData = $request->validate([
             'content' => 'required|array',
             'metadata' => 'nullable|array',
@@ -182,9 +179,8 @@ public function sendMessage(Request $request, $slug, MessageContentValidator $co
     }
 
 
-    public function updateMessage(Request $request, $slug, ApiRequestMigrator $requestMigrator): JsonResponse
+    public function updateMessage(Request $request, $slug): JsonResponse
     {
-        $request = $requestMigrator->migrate($request);
         $validatedData = $request->validate([
             'content' => 'required|array',
             'metadata' => 'nullable|array',
@@ -214,9 +210,8 @@ public function retrieveMessage($slug, $message_id): JsonResponse
     }
 
 
-    public function markAsRead(Request $request, $slug, ApiRequestMigrator $migrator): JsonResponse
+    public function markAsRead(Request $request, $slug): JsonResponse
     {
-        $request = $migrator->migrate($request);
         $validatedData = $request->validate([
             'message_id' => 'required|string',
         ]);

app/Http/Controllers/StreamController.php

@@ -16,8 +16,6 @@
 use App\Services\Ai\Values\Chunks\MaxToolExecutionsChunk;
 use App\Services\Ai\Values\Chunks\StreamDoneChunk;
 use App\Services\Ai\Values\TokenUsage;
-use App\Services\Api\ApiRequestMigrator;
-use App\Services\Api\Value\ApiRequestFieldConfig;
 use App\Services\Chat\Message\Handlers\GroupMessageHandler;
 use App\Services\Storage\AvatarStorageService;
 use App\Services\Storage\Values\StoredFileIdentifier;
@@ -87,12 +85,8 @@ public function handleExternalRequest(Request $request)
     /**
      * Handle AI connection requests using the new architecture
      */
-    public function handleAiConnectionRequest(Request $request, ApiRequestMigrator $requestMigrator)
+    public function handleAiConnectionRequest(Request $request)
     {
-        $request = $requestMigrator->migrate(
-            $request,
-            new ApiRequestFieldConfig(messageIdField: 'messageId', threadIdField: 'threadIndex')
-        );
 
         //validate payload
         try {

app/Services/Ai/Values/ModelCapabilities.php

@@ -54,7 +54,7 @@
  *
  * @api
  */
-final class ModelCapabilities implements \JsonSerializable, CastableInstanceInterface
+class ModelCapabilities implements \JsonSerializable, CastableInstanceInterface
 {
     use Macroable;
 

app/Services/Ai/Values/ProviderSettings.php

@@ -45,7 +45,7 @@
  *
  * @api
  */
-final class ProviderSettings implements CastableInstanceInterface
+final class ProviderSettings implements CastableInstanceInterface, \JsonSerializable
 {
     use Macroable;
 
@@ -153,7 +153,7 @@ public function set(string $key, mixed $value): self
      */
     public function remove(string $key): self
     {
-        if (in_array($key, $this->instanceKeys, true)) {
+        if (array_key_exists($key, $this->instanceKeys)) {
             throw InvalidProviderSettingsOperationException::forRequiredInstanceKey($key);
         }
 
@@ -179,7 +179,7 @@ public static function fromArray(array $data): static
     public function toArray(): array
     {
         $data = $this->list;
-        foreach ($this->instanceKeys as $key) {
+        foreach (array_keys($this->instanceKeys) as $key) {
             if (isset($data[$key]) && $data[$key] instanceof CastableInstanceInterface) {
                 $data[$key] = $data[$key]->toArray();
                 if (empty($data[$key])) {
@@ -189,4 +189,10 @@ public function toArray(): array
         }
         return $data;
     }
+
+    /** Serializes to a plain array, identical to {@see toArray()}. */
+    public function jsonSerialize(): array
+    {
+        return $this->toArray();
+    }
 }

app/Services/Api/ApiRequestMigrator.php

@@ -59,8 +59,8 @@ public function set(string $id, mixed $service): self
      * Resolves the service registered under the given identifier.
      *
      * Resolution order:
-     *  1. Locally registered services (see {@see set()})
-     *  2. The injected container (see {@see setContainer()})
+     *  1. Locally registered services ({@see set()})
+     *  2. The injected container ({@see setContainer()})
      *
      * @throws ServiceLocatorException when the service is not found locally and no container is available.
      */
@@ -82,7 +82,7 @@ public function get(string $id): mixed
      * Pre-registered params bypass the container entirely — useful in tests to supply controlled values.
      *
      * @param string $executionId Execution identifier matching the one passed to {@see call()}.
-     * @param array  $params      Parameters spread into the callback as positional arguments.
+     * @param array $params Parameters spread into the callback as positional arguments.
      */
     public function setCallParams(string $executionId, array $params): self
     {
@@ -97,9 +97,9 @@ public function setCallParams(string $executionId, array $params): self
      *  1. Pre-registered params for the given execution ID (see {@see setCallParams()}) — spread as positional args.
      *  2. The injected container (see {@see setContainer()}) — resolved via {@see Container::call()}.
      *
-     * @param string|array $executionId  Callback identifier; arrays are joined with '.' so callers can build
+     * @param string|array $executionId Callback identifier; arrays are joined with '.' so callers can build
      *                                   dot-paths by passing segments (e.g. ['scope', 'apply', $key]).
-     * @param array|null   $parameters   Named parameters forwarded to {@see Container::call()} when falling back
+     * @param array|null $parameters Named parameters forwarded to {@see Container::call()} when falling back
      *                                   to the container. Has no effect when pre-registered params are present.
      * @throws ServiceLocatorException when no pre-registered params and no container are available.
      */