Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Add attachFileContent to JobConfig and ServiceFactory #1921

Closed
wants to merge 3 commits into from
Closed

Add attachFileContent to JobConfig and ServiceFactory #1921

wants to merge 3 commits into from

Conversation

gurbuzali
Copy link

Add description here

Checklist

  • Tags Set
  • Milestone Set
  • Any breaking changes are documented
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc
  • For code samples, code sample main readme is updated

Links to issues fixed (if any):

Fixes #1897

List of breaking changes:

  • ..

viliam-durina
viliam-durina reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@viliam-durina viliam-durina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this meant to be just a different way of attaching a file? Now the job will get a byte[] instead of a file.

@cangencer cangencer added this to the 4.1 milestone Feb 6, 2020
@devOpsHazelcast
Copy link
Contributor

devOpsHazelcast commented Apr 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cangencer cangencer modified the milestones: 4.1, 4.2 Apr 14, 2020
@mtopolnik
Copy link
Contributor

Wasn't this meant to be just a different way of attaching a file? Now the job will get a byte[] instead of a file.

Yes, we should just integrate into the concept of attaching files. The method should accept a file path and that will become an actual file when instantiating the job for execution.

@mtopolnik mtopolnik closed this Oct 28, 2020
@gurbuzali gurbuzali deleted the attach-file-content branch January 15, 2021 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viliam-durina viliam-durina viliam-durina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JobConfig.attachFileContent
5 participants
@gurbuzali @devOpsHazelcast @mtopolnik @viliam-durina @cangencer