resolve PR comments

Author: Cryplo

src/haz3lcore/derived/Measured.re

@@ -325,7 +325,6 @@ let of_segment =
             ~col=new_indent - origin.col,
           );
         // add seg to map and reset seg
-        //TODO(andrew): decide if should actually add linebreak here
         let map =
           add_piece_row(
             origin.row,

src/haz3lcore/lang/Token.re

@@ -42,7 +42,7 @@ let bounding_box = (t: t): Point.t =>
 /* Token Recognition Predicates */
 
 /* A. Secondary Notation (Comments, Whitespace, etc.)  */
-let empty = "";
+let empty = ""; /* This is invalid for view */
 let space = " ";
 let linebreak = "\n";
 let comment_regexp = regexp("^#[^#\n]*#$"); /* Multiline comments not supported */

src/web/view/NutMenu.re

@@ -116,7 +116,21 @@ let dev_group = (~globals: Globals.t) => {
         Benchmark: Settings.Update.t,
       ),
       ("𝑒", "Elaboration", globals.settings.core.elaborate, Elaborate),
-      ("↵", "Whitespace", globals.settings.secondary_icons, SecondaryIcons),
+    ],
+  );
+};
+
+let code_display_group = (~globals: Globals.t) => {
+  settings_group(
+    ~globals,
+    "Code Display",
+    [
+      (
+        "↵",
+        "Whitespace",
+        globals.settings.secondary_icons,
+        SecondaryIcons: Settings.Update.t,
+      ),
       (
         "a",
         "Animations",
@@ -139,12 +153,14 @@ let dev_group = (~globals: Globals.t) => {
     ),
   );
 };
+
 //("l", "Line Numbers", globals.settings.line_numbers, ToggleLineNumbers)
 let settings_menu = (~globals) => {
   [
     semantics_group(~globals),
     values_group(~globals),
     stepper_group(~globals),
     dev_group(~globals),
+    code_display_group(~globals),
   ];
 };

src/web/www/style/editor.css

@@ -67,7 +67,7 @@
 * to avoid inserting an extraneous whitespace context for inline
 * syntax views, e.g. type views in the cursor inspector */
 .code-text:after {
-  content: "";
+  content: "​";
 }