Skip to content

Commit 220f6ea

Browse files
authored
ezqms-730: better check for roles when changing members (#5527)
Signed-off-by: Alexey Zinoviev <[email protected]>
1 parent 844e393 commit 220f6ea

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

Diff for: plugins/document-resources/src/components/teamspace/CreateTeamspace.svelte

+1-2
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,7 @@
242242
243243
if (removedMembersSet.size > 0 && rolesAssignment !== undefined) {
244244
for (const [key, value] of Object.entries(rolesAssignment)) {
245-
rolesAssignment[key as Ref<Role>] =
246-
value !== undefined ? value.filter((m) => !removedMembersSet.has(m)) : undefined
245+
rolesAssignment[key as Ref<Role>] = value != null ? value.filter((m) => !removedMembersSet.has(m)) : undefined
247246
}
248247
}
249248

Diff for: plugins/lead-resources/src/components/CreateFunnel.svelte

+1-2
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,7 @@
140140
141141
if (removedMembersSet.size > 0 && rolesAssignment !== undefined) {
142142
for (const [key, value] of Object.entries(rolesAssignment)) {
143-
rolesAssignment[key as Ref<Role>] =
144-
value !== undefined ? value.filter((m) => !removedMembersSet.has(m)) : undefined
143+
rolesAssignment[key as Ref<Role>] = value != null ? value.filter((m) => !removedMembersSet.has(m)) : undefined
145144
}
146145
}
147146

Diff for: plugins/tracker-resources/src/components/projects/CreateProject.svelte

+1-2
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,7 @@
302302
303303
if (removedMembersSet.size > 0 && rolesAssignment !== undefined) {
304304
for (const [key, value] of Object.entries(rolesAssignment)) {
305-
rolesAssignment[key as Ref<Role>] =
306-
value !== undefined ? value.filter((m) => !removedMembersSet.has(m)) : undefined
305+
rolesAssignment[key as Ref<Role>] = value != null ? value.filter((m) => !removedMembersSet.has(m)) : undefined
307306
}
308307
}
309308

0 commit comments

Comments
 (0)