Last Deployment Status Should Reflect Deployment Status (kserve#4667)

Signed-off-by: Gavin Li <yli1109@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>

Author: HotsauceLee

pkg/apis/serving/v1beta1/inference_service_status.go

@@ -17,6 +17,7 @@ limitations under the License.
 package v1beta1
 
 import (
+	"fmt"
 	"reflect"
 	"strings"
 
@@ -350,18 +351,89 @@ func (ss *InferenceServiceStatus) PropagateRawStatus(
 	if !ok {
 		ss.Components[component] = ComponentStatusSpec{}
 	}
+	readyCondition := readyConditionsMap[component]
+	componentReadyCondition := &apis.Condition{
+		Type:   readyCondition,
+		Status: corev1.ConditionFalse,
+		Reason: "",
+	}
 
-	condition := getDeploymentCondition(deploymentList, appsv1.DeploymentAvailable)
-	if condition != nil && condition.Status == corev1.ConditionTrue {
+	availableCondition := getDeploymentCondition(deploymentList, appsv1.DeploymentAvailable)
+	if availableCondition != nil && availableCondition.Status == corev1.ConditionTrue {
+		componentReadyCondition = &apis.Condition{
+			Type:    readyCondition,
+			Status:  corev1.ConditionTrue,
+			Reason:  availableCondition.Reason,
+			Message: availableCondition.Message,
+		}
+	}
+	fmt.Printf("availableCondition %v\n", componentReadyCondition)
+
+	progressingCondition := getDeploymentCondition(deploymentList, appsv1.DeploymentProgressing)
+	if progressingCondition != nil {
+		if progressingCondition.IsFalse() {
+			if len(progressingCondition.Message) > 0 {
+				// If there is a message, we assume there was a problem, often the time ProgressDeadlineExceeded
+				componentReadyCondition = &apis.Condition{
+					Type:    readyCondition,
+					Status:  corev1.ConditionFalse,
+					Reason:  progressingCondition.Reason,
+					Message: progressingCondition.Message,
+				}
+			}
+		} else {
+			// If progressing condition is True, and the reason is set to NewReplicaSetAvailable, override component as ready.
+			// This is because progressing condition doesn't get set to false when deployment is complete.
+			// See https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#complete-deployment
+			if progressingCondition.IsTrue() {
+				if progressingCondition.Reason == "NewReplicaSetAvailable" {
+					componentReadyCondition = &apis.Condition{
+						Type:    readyCondition,
+						Status:  corev1.ConditionTrue,
+						Reason:  progressingCondition.Reason,
+						Message: progressingCondition.Message,
+					}
+				} else {
+					componentReadyCondition = &apis.Condition{
+						Type:    readyCondition,
+						Status:  corev1.ConditionUnknown,
+						Reason:  progressingCondition.Reason,
+						Message: progressingCondition.Message,
+					}
+				}
+			}
+		}
+	}
+
+	// The availableCondition being false is a critical signal that your application is not running as expected.
+	if availableCondition != nil && availableCondition.Status == corev1.ConditionFalse {
+		componentReadyCondition = &apis.Condition{
+			Type:    readyCondition,
+			Status:  corev1.ConditionFalse,
+			Reason:  availableCondition.Reason,
+			Message: availableCondition.Message,
+		}
+	}
+
+	replicaFailureCondition := getDeploymentCondition(deploymentList, appsv1.DeploymentReplicaFailure)
+	if replicaFailureCondition != nil && replicaFailureCondition.Status == corev1.ConditionTrue {
+		componentReadyCondition = &apis.Condition{
+			Type:    readyCondition,
+			Status:  corev1.ConditionFalse,
+			Reason:  replicaFailureCondition.Reason,
+			Message: replicaFailureCondition.Message,
+		}
+	}
+	if componentReadyCondition != nil && componentReadyCondition.Status == corev1.ConditionTrue {
 		statusSpec.URL = url
 	}
-	readyCondition := readyConditionsMap[component]
-	ss.SetCondition(readyCondition, condition)
+	fmt.Printf("availableCondition2 %v", componentReadyCondition)
+
+	ss.SetCondition(readyCondition, componentReadyCondition)
 	ss.Components[component] = statusSpec
 	ss.ObservedGeneration = deploymentList[0].Status.ObservedGeneration
 }
 
-//nolint:unparam
 func getDeploymentCondition(deploymentList []*appsv1.Deployment, conditionType appsv1.DeploymentConditionType) *apis.Condition {
 	condition := apis.Condition{}
 	var messages, reasons []string