misc/openlane: patch sed to be cross-platform

sed on BSD and GNU have different behaviour when it comes to the
-i flag. They behave the same when a backup file is specified,
but differently when no backup is specified.

Rework all invocations in order to get this working on osx.

Signed-off-by: Sean Cross <[email protected]>

Author: xobs

misc/openlane/meta.yaml

@@ -9,8 +9,12 @@ source:
   git_url: https://github.com/The-OpenROAD-Project/OpenLane
   git_rev: master
   patches:
+<<<<<<< Updated upstream
     - handle-unknown-terminal.patch # The-OpenROAD-Project/OpenLane#1662
     - disable-version-check.patch # conda versions differ from openlane metadata
+=======
+    - sed-fixup.patch
+>>>>>>> Stashed changes
 
 build:
   noarch: generic

misc/openlane/sed-fixup.patch

@@ -0,0 +1,181 @@
+diff --git a/Jenkinsfile b/Jenkinsfile
+index 712d98ec6..8a93a24d1 100644
+--- a/Jenkinsfile
++++ b/Jenkinsfile
+@@ -80,7 +80,8 @@ pipeline {
+                                 }
+                                 stage("${DESIGN} - Update OpenROAD commit") {
+                                     script { OLD_SHA  = sh (returnStdout: true, script: "python3 dependencies/tool.py -f commit openroad_app").trim(); }
+-                                    sh "sed -i s/${OLD_SHA}/${NEW_SHA}/ ./dependencies/tool_metadata.yml"
++                                    sh "sed -i.bak s/${OLD_SHA}/${NEW_SHA}/ ./dependencies/tool_metadata.yml"
++                                    sh "rm -f ./dependencies/tool_metadata.yml.bak"
+                                 }
+                                 stage("${DESIGN} - Run test") {
+                                     sh "make OPENLANE_IMAGE_NAME=current:latest TEST_DESIGN=${DESIGN} test";
+diff --git a/docker/cvc_rv/Dockerfile b/docker/cvc_rv/Dockerfile
+index 108349fd9..f8efff5b4 100644
+--- a/docker/cvc_rv/Dockerfile
++++ b/docker/cvc_rv/Dockerfile
+@@ -25,7 +25,8 @@ RUN curl -L ${CVC_RV_REPO}/tarball/${CVC_RV_COMMIT} | tar -xzC . --strip-compone
+     autoreconf -i && \
+     autoconf && \
+     ./configure --disable-nls --prefix=/build && \
+-    sed -i 's/api.parser.class/parser_class_name/' src/cdlParser.yy && \
++    sed -i.bak 's/api.parser.class/parser_class_name/' src/cdlParser.yy && \
++    rm -f src/cdlParser.yy.bak && \
+     make -j$(nproc) install
+ 
+ RUN mkdir -p /build/version/
+@@ -39,4 +40,3 @@ ENV PATH /build/bin:$PATH
+ 
+ COPY --from=builder /build /build
+ COPY --from=builder /build.tar.gz /build.tar.gz
+-
+diff --git a/docker/klayout/build_klayout.sh b/docker/klayout/build_klayout.sh
+index 83ca2f934..45afde32f 100644
+--- a/docker/klayout/build_klayout.sh
++++ b/docker/klayout/build_klayout.sh
+@@ -15,7 +15,8 @@ pylibdir="$distpackdir/klayout"
+ # clean bin directory
+ rm -rf $bininstdir
+ 
+-sed -i 's/-O2 -g/-O2/' /usr/lib64/qt5/mkspecs/linux-g++/qmake.conf
++sed -i.bak 's/-O2 -g/-O2/' /usr/lib64/qt5/mkspecs/linux-g++/qmake.conf
++rm -f /usr/lib64/qt5/mkspecs/linux-g++/qmake.conf.bak
+ 
+ # do the actual build
+ ./build.sh\
+@@ -49,4 +50,4 @@ echo "Stripping..."
+ strip ${bindir}/*
+ strip ${pylibdir}/*.so
+ strip ${libdir}/db_plugins/*.so*
+-strip ${libdir}/lay_plugins/*.so*
+\ No newline at end of file
++strip ${libdir}/lay_plugins/*.so*
+diff --git a/docker/openroad_app/Dockerfile b/docker/openroad_app/Dockerfile
+index 340dd4e48..3b6b4b720 100644
+--- a/docker/openroad_app/Dockerfile
++++ b/docker/openroad_app/Dockerfile
+@@ -75,8 +75,10 @@ COPY ./utils.py .
+ RUN python3 ./utils.py fetch-submodules-from-tarballs ${OPENROAD_APP_REPO} ${OPENROAD_APP_COMMIT}
+ 
+ # Build OpenROAD
+-RUN sed -i "s/GITDIR-NOTFOUND/${OPENROAD_APP_COMMIT}/" cmake/GetGitRevisionDescription.cmake
+-RUN sed -i "s/static char Cases/static signed char Cases/" third-party/abc/src/misc/extra/extraUtilMisc.c
++RUN sed -i.bak "s/GITDIR-NOTFOUND/${OPENROAD_APP_COMMIT}/" cmake/GetGitRevisionDescription.cmake
++RUN rm -f cmake/GetGitRevisionDescription.cmake.bak
++RUN sed -i.bak "s/static char Cases/static signed char Cases/" third-party/abc/src/misc/extra/extraUtilMisc.c
++RUN rm -f third-party/abc/src/misc/extra/extraUtilMisc.c.bak
+ RUN mkdir build && mkdir -p /build/version && mkdir install
+ RUN cd build && cmake -DCMAKE_INSTALL_PREFIX=$(pwd)/install ..
+ RUN cd build && make -j$(nproc)
+diff --git a/scripts/tcl_commands/all.tcl b/scripts/tcl_commands/all.tcl
+index 9e90500a2..91661b8ec 100755
+--- a/scripts/tcl_commands/all.tcl
++++ b/scripts/tcl_commands/all.tcl
+@@ -46,7 +46,8 @@ proc set_netlist {args} {
+     set ::env(CURRENT_NETLIST) $netlist
+ 
+     set replace [string map {/ \\/} $::env(CURRENT_NETLIST)]
+-    try_catch sed -i -e "s/\\(set ::env(CURRENT_NETLIST)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    try_catch sed -i.bak -e "s/\\(set ::env(CURRENT_NETLIST)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec rm -f "$::env(GLB_CFG_FILE).bak"
+ 
+     if { [info exists flags_map(-lec)] && $::env(LEC_ENABLE) && [file exists $previous_netlist] } {
+         logic_equiv_check -lhs $previous_netlist -rhs $netlist
+@@ -58,7 +59,8 @@ proc set_def {def} {
+     puts_verbose "Changing layout to '$def_relative'..."
+     set ::env(CURRENT_DEF) $def
+     set replace [string map {/ \\/} $def]
+-    exec sed -i -e "s/\\(set ::env(CURRENT_DEF)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec sed -i.bak -e "s/\\(set ::env(CURRENT_DEF)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec rm -f "$::env(GLB_CFG_FILE).bak"
+ }
+ 
+ proc set_odb {odb} {
+@@ -66,7 +68,8 @@ proc set_odb {odb} {
+     puts_verbose "Changing database to '$odb_relative'..."
+     set ::env(CURRENT_ODB) $odb
+     set replace [string map {/ \\/} $odb]
+-    exec sed -i -e "s/\\(set ::env(CURRENT_ODB)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec sed -i.bak -e "s/\\(set ::env(CURRENT_ODB)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec rm -f "$::env(GLB_CFG_FILE).bak"
+ }
+ 
+ proc set_sdc {sdc} {
+@@ -74,7 +77,8 @@ proc set_sdc {sdc} {
+     puts_verbose "Changing timing constraints to '$sdc_relative'..."
+     set ::env(CURRENT_SDC) $sdc
+     set replace [string map {/ \\/} $sdc]
+-    exec sed -i -e "s/\\(set ::env(CURRENT_SDC)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec sed -i.bak -e "s/\\(set ::env(CURRENT_SDC)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec rm -f "$::env(GLB_CFG_FILE).bak"
+ }
+ 
+ proc set_guide {guide} {
+@@ -82,7 +86,8 @@ proc set_guide {guide} {
+     puts_verbose "Changing guide to '$guide_relative'..."
+     set ::env(CURRENT_GUIDE) $guide
+     set replace [string map {/ \\/} $guide]
+-    exec sed -i -e "s/\\(set ::env(CURRENT_GUIDE)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec sed -i.bak -e "s/\\(set ::env(CURRENT_GUIDE)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++    exec rm -f "$::env(GLB_CFG_FILE).bak"
+ }
+ 
+ proc prep_lefs {args} {
+diff --git a/scripts/tcl_commands/magic.tcl b/scripts/tcl_commands/magic.tcl
+index 330ba1a5a..70dd27b68 100755
+--- a/scripts/tcl_commands/magic.tcl
++++ b/scripts/tcl_commands/magic.tcl
+@@ -51,7 +51,8 @@ proc run_magic {args} {
+             -indexed_log $log
+ 
+         # Only keep the properties section in the file
+-        try_catch sed -i -n "/^<< properties >>/,/^<< end >>/p" $::env(signoff_tmpfiles)/gds_ptrs.mag
++        try_catch sed -i.bak -n "/^<< properties >>/,/^<< end >>/p" $::env(signoff_tmpfiles)/gds_ptrs.mag
++        exec rm -f $::env(signoff_tmpfiles)/gds_ptrs.mag.bak
+     }
+ 
+     # If desired, copy GDS_* properties into the mag/ view
+diff --git a/scripts/tcl_commands/synthesis.tcl b/scripts/tcl_commands/synthesis.tcl
+index 9ec052468..fb8000e9c 100755
+--- a/scripts/tcl_commands/synthesis.tcl
++++ b/scripts/tcl_commands/synthesis.tcl
+@@ -71,7 +71,8 @@ proc run_yosys {args} {
+     if { [info exists ::env(SYNTH_EXPLORE)] && $::env(SYNTH_EXPLORE) } {
+         puts_info "This is a Synthesis Exploration and so no need to remove the defparam lines."
+     } else {
+-        try_catch sed -i {/defparam/d} $arg_values(-output)
++        try_catch sed -i.bak {/defparam/d} $arg_values(-output)
++        exec rm -f $arg_values(-output).bak
+     }
+     unset ::env(SAVE_NETLIST)
+ }
+diff --git a/scripts/utils/deflef_utils.tcl b/scripts/utils/deflef_utils.tcl
+index a2ef69124..9a62019e6 100755
+--- a/scripts/utils/deflef_utils.tcl
++++ b/scripts/utils/deflef_utils.tcl
+@@ -26,7 +26,8 @@ proc resize_die {args} {
+     set ury [expr {[lindex $arg_values(-area) 3] * $::env(DEF_UNITS_PER_MICRON)}]
+ 
+     puts_info "Resizing Die to $arg_values(-area)"
+-    try_catch sed -i -E "0,/^DIEAREA.*$/{s/^DIEAREA.*$/DIEAREA ( $llx $lly ) ( $urx $ury ) ;/}" $arg_values(-def)
++    try_catch sed -i.bak -E "0,/^DIEAREA.*$/{s/^DIEAREA.*$/DIEAREA ( $llx $lly ) ( $urx $ury ) ;/}" $arg_values(-def)
++    try_catch rm -f $arg_values(-def).bak
+ }
+ 
+ proc get_instance_position {args} {
+diff --git a/scripts/utils/utils.tcl b/scripts/utils/utils.tcl
+index 4209a3b1a..aa7e9e8a4 100755
+--- a/scripts/utils/utils.tcl
++++ b/scripts/utils/utils.tcl
+@@ -209,7 +209,8 @@ proc index_file {args} {
+     set new_file_full_name "$file_path/$fbasename"
+     set replace [string map {/ \\/} $::env(CURRENT_INDEX)]
+     if { [info exists ::env(GLB_CFG_FILE)]} {
+-        exec sed -i -e "s/\\(set ::env(CURRENT_INDEX)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++        exec sed -i.bak -e "s/\\(set ::env(CURRENT_INDEX)\\).*/\\1 $replace/" "$::env(GLB_CFG_FILE)"
++        exec rm -f "$::env(GLB_CFG_FILE).bak"
+     }
+     return $new_file_full_name
+ }