Skip to content

Commit 326419d

Browse files
committed
ci: keep hidapi 0.14.0 visible in 1.11 leg's PKG_CONFIG_PATH
The matrix 1.11 leg set PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig to select the system TagLib 1.11. But pkg-config searches that path first, and Focal's libhidapi-dev also installs an old hidapi-libusb.pc (0.9.0) there, which shadowed the freshly built hidapi 0.14.0 in /usr/local/lib/pkgconfig and broke configure at the hidapi >= 0.14.0 check. Prepend /usr/local/lib/pkgconfig so the built hidapi 0.14.0 .pc wins, while system TagLib 1.11 still resolves from the second entry (/usr/local has no taglib.pc). Document the non-obvious precedence in the setup step comment.
1 parent 9dfdded commit 326419d

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/ubuntu-20.04-qt6-taglib22-build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
artifact_tag: taglib22
3131
- taglib_version: "1.11"
3232
taglib_prefix: /usr
33-
taglib_pkgconfig: /usr/lib/x86_64-linux-gnu/pkgconfig
33+
taglib_pkgconfig: /usr/local/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig
3434
build_taglib_from_source: false
3535
artifact_tag: taglib111
3636
runs-on: ubuntu-24.04
@@ -114,6 +114,11 @@ jobs:
114114
# support. The 2.2 leg overrides it by putting /opt/taglib/2.2 first
115115
# in PKG_CONFIG_PATH; the 1.11 leg uses the system package and thus
116116
# exercises the FFmpeg metadata fallback path.
117+
# The 1.11 leg's PKG_CONFIG_PATH puts /usr/local/lib/pkgconfig first
118+
# so the freshly built hidapi 0.14.0 .pc wins over the apt one
119+
# (0.9.0) that /usr/lib/x86_64-linux-gnu/pkgconfig would otherwise
120+
# shadow; /usr/local has no taglib.pc, so system TagLib 1.11 still
121+
# resolves from the second entry.
117122
118123
- name: Build hidapi 0.14.0 (Focal ships 0.9.0)
119124
shell: bash

0 commit comments

Comments
 (0)