Skip to content

Commit 4bd3901

Browse files
committed
ci: match libtag name in TagLib linkage check
The ldd line reads 'libtag.so.1', which does not contain the substring 'taglib'. Under set -o pipefail the grep returned 1 and aborted the step before the case check, so the realpath fix could never be validated. Match 'libtag' instead.
1 parent cfb355b commit 4bd3901

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/ubuntu-20.04-qt6-taglib22-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ jobs:
270270
lib=$(ldd build/mixxx 2>/dev/null | awk '/libtag\.so/{print $3}' | head -1)
271271
lib_real=$(realpath -e "${lib}" 2>/dev/null || echo "${lib}")
272272
echo "libtag resolved to: ${lib} (canonical: ${lib_real})"
273-
ldd build/mixxx 2>&1 | grep -i taglib | tee logs/09-taglib-linkage.log
273+
ldd build/mixxx 2>&1 | grep -i 'libtag' | tee logs/09-taglib-linkage.log
274274
case "${lib_real}" in
275275
${TAGLIB_PREFIX}/*)
276276
echo "OK: mixxx links TagLib ${TAGLIB_VERSION} from ${TAGLIB_PREFIX}"

0 commit comments

Comments
 (0)