Migrations failing on 'well' designed tables

[pacMakaveli]

I've been using Devise for years and today, for

my migration failed because, well, I designed my table properly..

== TIMESTAMP AddDeviseToUsers: migrating =================================
-- change_table(:users)
bin/rails aborted!
StandardError: An error has occurred, this and all later migrations canceled: (StandardError)

PG::DuplicateColumn: ERROR:  column "email" of relation "users" already exists
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:7:in 'block in AddDeviseToUsers.up'
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:5:in 'AddDeviseToUsers.up'

Caused by:
ActiveRecord::StatementInvalid: PG::DuplicateColumn: ERROR:  column "email" of relation "users" already exists (ActiveRecord::StatementInvalid)
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:7:in 'block in AddDeviseToUsers.up'
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:5:in 'AddDeviseToUsers.up'

Caused by:
PG::DuplicateColumn: ERROR:  column "email" of relation "users" already exists (PG::DuplicateColumn)
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:7:in 'block in AddDeviseToUsers.up'
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:5:in 'AddDeviseToUsers.up'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

and

== TIMESTAMP AddDeviseToUsers: migrating =================================
-- change_table(:users)
   -> 0.0444s
-- add_index(:users, :email, {unique: true})
bin/rails aborted!
StandardError: An error has occurred, this and all later migrations canceled: (StandardError)

PG::DuplicateTable: ERROR:  relation "index_users_on_email" already exists
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:39:in 'AddDeviseToUsers.up'

Caused by:
ActiveRecord::StatementInvalid: PG::DuplicateTable: ERROR:  relation "index_users_on_email" already exists (ActiveRecord::StatementInvalid)
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:39:in 'AddDeviseToUsers.up'

Caused by:
PG::DuplicateTable: ERROR:  relation "index_users_on_email" already exists (PG::DuplicateTable)
/path/to/project/db/migrate/TIMESTAMP_add_devise_to_users.rb:39:in 'AddDeviseToUsers.up'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

It's not that big of a thing as the fix is quite trivial, but I feel like this shouldn't happen in the first place.

My proposed fix would be to add some checks in: lib/generators/active_record/templates/migration_existing.rb

add_index :<%= table_name %>, :email, unique: true, if_not_exists: true

and

<% attributes.each do |attribute| -%>
  t.<%= attribute.type %> :<%= attribute.name %> unless t.column_exists?(attribute)
<% end -%>

Happy to sort a PR for this if we're all in agreement.

[adoniranfranceh]

Hi! I saw that this issue is still open, and the suggested solution makes sense. Would it be okay if I open a PR implementing this change?

[pacMakaveli]

Hey @adoniranfranceh -- I didn't want to do it and not have it merged. I value my time 👯
If you've got the bandwidth, by all means, go ahead. Happy to give it a spin once you've got it up and running.

[gregmolnar]

I believe it would be a nice addition, but we need to sort out maintenance of the gem to get things merged.

[pacMakaveli]

Yeah, this kind of sucks. @gregmolnar is there any interest from anyone in taking over? I’ve been using Devise for 10 years and really depend on it—I can’t afford to see it fade away, yet anyway.

If no one else is willing to step in, I’d be happy to fork it and continue maintenance to ensure it stays alive and well.

[gregmolnar]

I am trying to get a hold of the maintainers and I would be willing to take it over, but help would be appreciated if that happens. I am also responsible for a few apps that relies on Devise and I could dedicated a few hours per week to the project.