test: cover denied permission outcomes (#51)

Author: chicoxyzzy

codexadapter/adapter_test.go

@@ -3,12 +3,14 @@ package codexadapter_test
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 	"os"
 	"path/filepath"
 	"reflect"
 	"runtime"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/hecatehq/acp-adapter-kit/acptest"
 	"github.com/hecatehq/acp-adapter-kit/adaptertest"
@@ -655,6 +657,70 @@ printf '{"method":"item/completed","params":{"item":{"type":"agent_message","id"
 	}
 }
 
+func TestNewServerStopsCodexStreamWhenPermissionDenied(t *testing.T) {
+	tests := []struct {
+		name       string
+		option     acptest.LiveClientOption
+		wantReason string
+	}{
+		{
+			name:       "rejected",
+			option:     acptest.WithAutoRejectPermissions(),
+			wantReason: "permission rejected for Run tests",
+		},
+		{
+			name:       "cancelled",
+			option:     acptest.WithAutoCancelPermissions(),
+			wantReason: "permission cancelled for Run tests",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			installFakeCommand(t, "codex", `
+if [ "$1" != "exec" ]; then
+  echo "unexpected command: $*" >&2
+  exit 64
+fi
+printf '{"method":"permission/requested","params":{"toolCall":{"toolCallId":"tool-1","title":"Run tests","kind":"execute","rawInput":{"command":"go test ./..."}},"options":[{"optionId":"allow","name":"Allow","kind":"allow_once"},{"optionId":"reject","name":"Reject","kind":"reject_once"}]}}\n'
+printf '{"method":"item/completed","params":{"item":{"type":"agent_message","id":"msg-1","text":"should not continue"}}}\n'
+	`)
+			client := acptest.NewLiveClient(t, codexadapter.NewServer("test"), tt.option)
+			client.Request("initialize", "initialize", map[string]any{}, time.Second)
+			createdResponses := client.Request("new-session", "session/new", map[string]any{"cwd": t.TempDir()}, time.Second)
+			var session struct {
+				SessionID string `json:"sessionId"`
+			}
+			createdResponses[len(createdResponses)-1].ResultInto(t, &session)
+
+			responses := client.PromptText("prompt", session.SessionID, "hello", time.Second)
+			if len(responses) < 3 {
+				t.Fatalf("responses = %#v, want tool start + permission request + prompt error", responses)
+			}
+			permission := decodePermissionRequest(t, responses[1])
+			if permission.ToolCall.ToolCallID != "tool-1" ||
+				permission.ToolCall.Title != "Run tests" ||
+				permission.ToolCall.Kind != "execute" {
+				t.Fatalf("permission = %#v, want Codex stream permission request", permission)
+			}
+			for _, response := range responses {
+				if response.Method != "session/update" {
+					continue
+				}
+				update := decodeSessionUpdate(t, response)
+				if update.Update.SessionUpdate == "agent_message_chunk" {
+					t.Fatalf("responses = %#v, did not expect assistant continuation after denied permission", responses)
+				}
+			}
+			final := responses[len(responses)-1]
+			if final.Error == nil ||
+				final.Error.Message != "prompt command failed" ||
+				!strings.Contains(fmt.Sprint(final.Error.Data), tt.wantReason) {
+				t.Fatalf("final response = %#v, want prompt command failed with %q", final, tt.wantReason)
+			}
+		})
+	}
+}
+
 func TestPromptCommandRequiresWorkspace(t *testing.T) {
 	_, err := codexadapter.PromptCommand(commandbridge.Session{}, runtimeacp.PromptParams{
 		Prompt: []runtimeacp.ContentBlock{{Type: "text", Text: "hello"}},

docs/TESTING.md

@@ -144,8 +144,8 @@ production-grade.
   command prompts, and prompt completion
 - source-shaped Codex stream fixtures for permission requests, including
   MCP `server/tool` permission labels, option alias/default handling,
-  shell/tool lifecycle updates, reasoning chunks, usage, and terminal stop
-  reasons
+  shell/tool lifecycle updates, reasoning chunks, usage, terminal stop reasons,
+  and live ACP client coverage for rejected and cancelled permission outcomes
 - auth-required error classification for native Codex failures, including the
   HTTP 401 "missing bearer or basic authentication" shape
 - opt-in real Codex CLI smoke coverage that requires an authenticated local

go.mod

@@ -7,7 +7,7 @@ require github.com/spf13/cobra v1.10.1 // indirect
 require github.com/coder/acp-go-sdk v0.13.5 // indirect
 
 require (
-	github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.6
+	github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.7
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/spf13/pflag v1.0.9 // indirect
 )

go.sum

@@ -1,8 +1,8 @@
 github.com/coder/acp-go-sdk v0.13.5 h1:LI9jq5xon7xslaYlnoktvTVyDlE37yIk2daT7N9ASYk=
 github.com/coder/acp-go-sdk v0.13.5/go.mod h1:yKzM/3R9uELp4+nBAwwtkS0aN1FOFjo11CNPy37yFko=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.6 h1:udz5nA6Nms6m0DwPzWQJ9SU/gYrHSLAPj1+xQjT4Wi8=
-github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.6/go.mod h1:7Wl6fSNPnS2t7EgrLspkEQ5YGjp+yaStebHEHIRjqD8=
+github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.7 h1:i3yl7JhF5JEF10gpXaslnLm9I4aC2+UUyIrSpP7Ked8=
+github.com/hecatehq/acp-adapter-kit v0.1.0-alpha.7/go.mod h1:7Wl6fSNPnS2t7EgrLspkEQ5YGjp+yaStebHEHIRjqD8=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=