Merge pull request #42 from heetch/fix-panic

Fix panicking

Author: Yasss

consumer/consumer.go

@@ -81,7 +81,7 @@ func (c *Consumer) setup() {
 		}
 	}
 
-	if c.retryStrategy == nil {
+	if c.config != nil && c.retryStrategy == nil {
 		// Note: the logic in handleMsg assumes that
 		// this does not terminate; be aware of that when changing
 		// this strategy.
@@ -101,14 +101,14 @@ func (c *Consumer) setup() {
 // When Serve terminates it will return an Error or nil to indicate
 // that it excited without error.
 func (c *Consumer) Serve(config Config, addrs ...string) error {
-	c.setup()
-
 	c.config = &config
 	err := c.validateConfig()
 	if err != nil {
 		return err
 	}
 
+	c.setup()
+
 	topics := c.handlers.Topics()
 
 	consumerGroup := fmt.Sprintf("%s-consumer-group", c.config.ClientID)
@@ -239,7 +239,8 @@ func (c *Consumer) handleMsg(msg *sarama.ConsumerMessage) (*Message, int) {
 		}
 		return m, attempts
 	}
-	panic("unreachable")
+	return nil, attempts
+
 }
 
 // MetricsReporter is an interface that can be passed to set metrics hook to receive metrics