Skip to content

Commit 605137d

Browse files
committed
claude: simplify min-version step and skip antithesis tests in test-min-protocol
Apply review suggestion to remove redundant name/comments in the min-version CI step. Skip antithesis tests in the min-protocol job since they spawn subprocess projects that inherit HEGEL_SERVER_COMMAND and the old hegel-core doesn't support them.
1 parent 82ae375 commit 605137d

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,18 +108,14 @@ jobs:
108108
with:
109109
tools: just uv
110110

111-
- name: Determine minimum hegel-core version
112-
id: min-version
111+
- id: min-version
113112
run: |
114-
# Read the lower bound of SUPPORTED_PROTOCOL_VERSIONS from runner.rs
115113
MIN_PROTOCOL=$(grep -oE 'SUPPORTED_PROTOCOL_VERSIONS.*\(([0-9.]+)' src/runner.rs | grep -oE '[0-9.]+$')
116-
echo "Minimum supported protocol version: $MIN_PROTOCOL"
117114
118-
# Fetch the version mapping from hegel.dev
119115
VERSIONS_JSON=$(curl -sf https://hegel.dev/api/versions.json)
120116
121-
# Look up the earliest hegel-core version for this protocol
122117
MIN_CORE=$(echo "$VERSIONS_JSON" | python3 -c "import sys,json; print(json.load(sys.stdin)['$MIN_PROTOCOL'])")
118+
echo "Minimum supported protocol version: $MIN_PROTOCOL"
123119
echo "Minimum hegel-core version: $MIN_CORE"
124120
echo "min_core=$MIN_CORE" >> "$GITHUB_OUTPUT"
125121
@@ -128,7 +124,9 @@ jobs:
128124
MIN_CORE: ${{ steps.min-version.outputs.min_core }}
129125
run: |
130126
uv tool install "hegel-core==$MIN_CORE"
131-
HEGEL_SERVER_COMMAND=$(which hegel) just check-tests
127+
# Skip antithesis tests: they spawn subprocess projects that inherit
128+
# HEGEL_SERVER_COMMAND and the old server doesn't support them.
129+
HEGEL_SERVER_COMMAND=$(which hegel) RUST_BACKTRACE=1 cargo test -- --skip test_antithesis
132130
133131
docs:
134132
name: docs

0 commit comments

Comments
 (0)