-
Notifications
You must be signed in to change notification settings - Fork 9
Expand file tree
/
Copy pathhpr_multi_buy.erl
More file actions
248 lines (210 loc) · 8.02 KB
/
hpr_multi_buy.erl
File metadata and controls
248 lines (210 loc) · 8.02 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
-module(hpr_multi_buy).
-include("grpc/autogen/multi_buy_pb.hrl").
-include("hpr.hrl").
-export([
init/0,
update_counter/2,
cleanup/1,
make_key/2,
enabled/0
]).
-define(ETS, hpr_multi_buy_ets).
-define(MULTIBUY, multi_buy).
-define(MAX_TOO_LOW, multi_buy_max_too_low).
-define(CLEANUP_TIME, timer:minutes(30)).
-spec init() -> ok.
init() ->
%% Table structure
%% {Key :: binary(), Counter :: non_neg_integer() :: Timestamp :: integer()}
ets:new(?ETS, [
public,
named_table,
set,
{write_concurrency, true}
]),
ok = scheduled_cleanup(?CLEANUP_TIME),
ok.
-spec update_counter(Key :: binary(), Max :: non_neg_integer()) ->
{ok, boolean()} | {error, ?MAX_TOO_LOW | ?MULTIBUY}.
update_counter(_Key, Max) when Max =< 0 ->
{error, ?MAX_TOO_LOW};
update_counter(Key, Max) ->
case
ets:update_counter(
?ETS, Key, {2, 1}, {default, 0, erlang:system_time(millisecond)}
)
of
LocalCounter when LocalCounter > Max ->
{error, ?MULTIBUY};
LocalCounter ->
case enabled() of
false ->
%% ETS-only mode: no external service configured
{ok, false};
true ->
case request(Key) of
{ok, ServiceCounter} when ServiceCounter > Max ->
ets:update_counter(
?ETS,
Key,
{2, Max - LocalCounter + 1},
{default, 0, erlang:system_time(millisecond)}
),
{error, ?MULTIBUY};
{ok, _ServiceCounter} ->
{ok, false};
{error, Reason} ->
lager:error("failed to get a counter for ~s: ~p", [
hpr_utils:bin_to_hex_string(Key), Reason
]),
{ok, true}
end
end
end.
-spec cleanup(Duration :: non_neg_integer()) -> ok.
cleanup(Duration) ->
erlang:spawn(fun() ->
Time = erlang:system_time(millisecond) - Duration,
Deleted = ets:select_delete(?ETS, [
{{'_', '_', '$3'}, [{'<', '$3', Time}], [true]}
]),
lager:debug("expiring ~w keys", [Deleted])
end),
ok.
-spec make_key(hpr_packet_up:packet(), hpr_route:route()) -> binary().
make_key(PacketUp, Route) ->
crypto:hash(sha256, <<
(hpr_packet_up:phash(PacketUp))/binary,
(hpr_route:lns(Route))/binary
>>).
%% ------------------------------------------------------------------
%% Internal Function Definitions
%% ------------------------------------------------------------------
-spec enabled() -> boolean().
enabled() ->
application:get_env(hpr, multi_buy_enabled, true).
-spec scheduled_cleanup(Duration :: non_neg_integer()) -> ok.
scheduled_cleanup(Duration) ->
{ok, _} = timer:apply_interval(Duration, ?MODULE, cleanup, [Duration]),
ok.
-spec request(Key :: binary()) -> {ok, non_neg_integer()} | {error, any()}.
request(Key) ->
{Time, Result} = timer:tc(fun() ->
Req = #multi_buy_inc_req_v1_pb{key = hpr_utils:bin_to_hex_string(Key)},
try helium_multi_buy_multi_buy_client:inc(Req, #{channel => ?MULTI_BUY_CHANNEL}) of
{ok, #multi_buy_inc_res_v1_pb{count = Count}, _} ->
{ok, Count};
_Any ->
{error, _Any}
catch
exit:{timeout, _Error} -> {error, timeout};
Any -> {error, Any}
end
end),
hpr_metrics:observe_multi_buy(Result, Time),
Result.
%% ------------------------------------------------------------------
%% EUNIT Tests
%% ------------------------------------------------------------------
-ifdef(TEST).
-include_lib("eunit/include/eunit.hrl").
-define(TEST_SLEEP, 250).
-define(TEST_PERF, 1000).
all_test_() ->
{foreach, fun foreach_setup/0, fun foreach_cleanup/1, [
?_test(test_max_too_low()),
?_test(test_update_counter()),
?_test(test_update_counter_with_service()),
?_test(test_update_counter_ets_only()),
?_test(test_cleanup()),
?_test(test_scheduled_cleanup())
]}.
foreach_setup() ->
meck:new(hpr_metrics, [passthrough]),
meck:expect(hpr_metrics, observe_multi_buy, fun(_, _) -> ok end),
meck:new(helium_multi_buy_multi_buy_client, [passthrough]),
meck:expect(helium_multi_buy_multi_buy_client, inc, fun(_, _) -> {error, not_implemented} end),
ok = ?MODULE:init(),
application:set_env(hpr, multi_buy_enabled, true),
ok.
foreach_cleanup(ok) ->
_ = catch ets:delete(?ETS),
?assert(meck:validate(hpr_metrics)),
meck:unload(hpr_metrics),
?assert(meck:validate(helium_multi_buy_multi_buy_client)),
meck:unload(helium_multi_buy_multi_buy_client),
application:set_env(hpr, multi_buy_enabled, false),
ok.
test_max_too_low() ->
Key = crypto:strong_rand_bytes(16),
Max = 0,
?assertEqual({error, ?MAX_TOO_LOW}, ?MODULE:update_counter(Key, Max)),
ok.
test_update_counter() ->
Key = crypto:strong_rand_bytes(16),
Max = 3,
?assertEqual({ok, true}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, true}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, true}, ?MODULE:update_counter(Key, Max)),
?assertEqual({error, ?MULTIBUY}, ?MODULE:update_counter(Key, Max)),
ok.
test_update_counter_with_service() ->
Key = crypto:strong_rand_bytes(16),
Max = 3,
meck:expect(helium_multi_buy_multi_buy_client, inc, fun(#multi_buy_inc_req_v1_pb{key = K}, _) ->
Map = persistent_term:get(test_update_counter_with_service_map, #{}),
OldCount = maps:get(K, Map, 0),
NewCount = OldCount + 1,
persistent_term:put(test_update_counter_with_service_map, Map#{K => NewCount}),
{ok, #multi_buy_inc_res_v1_pb{count = NewCount}, undefined}
end),
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
?assertEqual({error, ?MULTIBUY}, ?MODULE:update_counter(Key, Max)),
ok.
test_update_counter_ets_only() ->
%% Disable external multi-buy service (ETS-only mode)
application:set_env(hpr, multi_buy_enabled, false),
Key = crypto:strong_rand_bytes(16),
Max = 3,
%% The external service should never be called in ETS-only mode
meck:expect(helium_multi_buy_multi_buy_client, inc, fun(_, _) ->
error(should_not_be_called)
end),
%% In ETS-only mode, successful updates return {ok, false} (not free)
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
?assertEqual({ok, false}, ?MODULE:update_counter(Key, Max)),
%% Once max is exceeded, still get multi_buy error from local ETS
?assertEqual({error, ?MULTIBUY}, ?MODULE:update_counter(Key, Max)),
%% Re-enable for other tests
application:set_env(hpr, multi_buy_enabled, true),
ok.
test_cleanup() ->
Key1 = crypto:strong_rand_bytes(16),
Key2 = crypto:strong_rand_bytes(16),
Max = 1,
?assertEqual({ok, true}, ?MODULE:update_counter(Key1, Max)),
?assertEqual({ok, true}, ?MODULE:update_counter(Key2, Max)),
?assertEqual(2, ets:info(?ETS, size)),
timer:sleep(50),
?assertEqual(ok, ?MODULE:cleanup(10)),
timer:sleep(50),
?assertEqual(0, ets:info(?ETS, size)),
ok.
test_scheduled_cleanup() ->
Key1 = crypto:strong_rand_bytes(16),
Key2 = crypto:strong_rand_bytes(16),
Max = 1,
?assertEqual({ok, true}, ?MODULE:update_counter(Key1, Max)),
?assertEqual({ok, true}, ?MODULE:update_counter(Key2, Max)),
?assertEqual(2, ets:info(?ETS, size)),
timer:sleep(50),
%% This will cleanup in 25ms
?assertEqual(ok, scheduled_cleanup(25)),
?assertEqual(2, ets:info(?ETS, size)),
timer:sleep(50),
?assertEqual(0, ets:info(?ETS, size)),
ok.
-endif.