Skip to content

Pin git dependencies to revs instead of branches #540

Description

@madninja

From a supply-chain review. Several dependencies ride git branches rather than pinned revs:

  • [patch.crates-io] anchor-lang → personal fork, branch madninja/const_pubkey (root Cargo.toml)
  • helium-proto → branch master
  • msg-signature → branch master
  • tuktuk-sdk → branch main
  • squads-multisig-program → branch main

Cargo.lock pins exact commits today, but any fresh resolution (lockfile regenerated, downstream consumer without the lock) follows the branch tip. For the anchor patch and the multisig program this is the on-chain-money path.

Suggested fix: switch each to rev = "<sha>", and longer-term either upstream the anchor const_pubkey change or vendor it so the workspace doesn't depend on a personal branch staying alive.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions