Fix crashing on not enough free tasks and add better logging of simul… (#32)

* Fix crashing when not enough free tasks

* Fix crashing on not enough free tasks and add better logging of simulated failures

Author: ChewingGlass

Cargo.lock

@@ -78,6 +78,8 @@ impl PackedTransaction {
                     .map(|a| a.pubkey)
                     .collect_vec()
             })
+            .collect::<std::collections::HashSet<_>>()
+            .into_iter()
             .collect_vec();
         if signers.is_empty() {
             signers.push(Pubkey::default());

solana-transaction-utils/src/pack.rs

@@ -8,6 +8,7 @@ use solana_sdk::{
     signature::NullSigner,
     transaction::VersionedTransaction,
 };
+use tracing::info;
 
 use crate::error::Error;
 
@@ -145,6 +146,7 @@ pub async fn compute_budget_for_instructions<C: AsRef<RpcClient>>(
     // Simulate the transaction to get the actual compute used
     let simulation_result = client.as_ref().simulate_transaction(&snub_tx).await?;
     if let Some(err) = simulation_result.value.err {
+        info!(?simulation_result.value.logs, "simulation error");
         return Err(Error::SimulatedTransactionError(err));
     }
     let actual_compute_used = simulation_result.value.units_consumed.unwrap_or(200000);

solana-transaction-utils/src/priority_fee.rs

@@ -15,6 +15,7 @@ use tokio::{
     sync::mpsc::{channel, Receiver, Sender},
     time::{interval, Interval},
 };
+use tracing::info;
 
 use crate::{
     error::Error,
@@ -110,6 +111,10 @@ pub async fn create_transaction_queue<T: Send + Clone + 'static + Sync>(
                 )
                 .await?;
 
+            if let Some(err) = sim_result.value.err.clone() {
+                info!(?err, ?sim_result.value.logs, "simulation error");
+            }
+
             // Scale up by 1.2 just to be sure it'll succeed.
             let compute_units =
                 (sim_result.value.units_consumed.unwrap_or(1000000) as f64 * 1.2) as u32;

solana-transaction-utils/src/queue.rs

@@ -1,6 +1,6 @@
 [package]
 name = "tuktuk-crank-turner"
-version = "0.2.15"
+version = "0.2.16"
 authors.workspace = true
 edition.workspace = true
 license.workspace = true

tuktuk-crank-turner/Cargo.toml

@@ -81,7 +81,10 @@ impl TimedTask {
         Ok(result)
     }
 
-    pub async fn get_available_task_ids(&self, ctx: Arc<TaskContext>) -> anyhow::Result<Vec<u16>> {
+    pub async fn get_available_task_ids(
+        &self,
+        ctx: Arc<TaskContext>,
+    ) -> Result<Vec<u16>, tuktuk_sdk::error::Error> {
         let task_queue = self.get_task_queue(ctx.clone()).await?;
         let mut in_progress = ctx.in_progress_tasks.lock().await;
         let mut task_ids = in_progress
@@ -163,7 +166,11 @@ impl TimedTask {
             return self.handle_ix_err(ctx.clone(), err).await;
         }
         let lookup_tables = maybe_lookup_tables.unwrap();
-        let next_available = self.get_available_task_ids(ctx.clone()).await?;
+        let maybe_next_available = self.get_available_task_ids(ctx.clone()).await;
+        if let Err(err) = maybe_next_available {
+            return self.handle_ix_err(ctx.clone(), err).await;
+        }
+        let next_available = maybe_next_available.unwrap();
         self.in_flight_task_ids = next_available.clone();
 
         let maybe_run_ix = if let Some(cached_result) = self.cached_result.clone() {