Fix audit bugs (#75)

Author: ChewingGlass

solana-programs/programs/cron/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cron"
-version = "0.2.5"
+version = "0.2.6"
 description = "Created with Anchor"
 edition = "2021"
 

solana-programs/programs/cron/src/instructions/add_cron_transaction_v0.rs

@@ -21,7 +21,7 @@ pub struct AddCronTransactionV0<'info> {
     #[account(mut, has_one = authority)]
     pub cron_job: Box<Account<'info, CronJobV0>>,
     #[account(
-        init_if_needed,
+        init,
         payer = payer,
         seeds = [b"cron_job_transaction", cron_job.key().as_ref(), &args.index.to_le_bytes()[..]],
         bump,

solana-programs/programs/tuktuk/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "tuktuk"
-version = "0.2.4"
+version = "0.2.5"
 description = "Created with Anchor"
 edition = "2021"
 

tuktuk-program/src/write_return_tasks.rs

@@ -68,6 +68,7 @@ where
     };
 
     let mut total_tasks = 0;
+    let mut has_unprocessed_tasks = true;
     for AccountWithSeeds { account, seeds } in accounts.iter() {
         // Store original size before any reallocation
         original_sizes.push(account.data_len());
@@ -102,6 +103,7 @@ where
         loop {
             let task_bytes = current_task.try_to_vec()?;
             if offset + task_bytes.len() > MAX_PERMITTED_DATA_INCREASE {
+                has_unprocessed_tasks = true;
                 break; // This task will be handled by the next account
             }
 
@@ -112,12 +114,14 @@ where
             total_tasks += 1;
 
             // Get next task
-            match tasks.next() {
-                Some(task) => current_task = task,
+            current_task = match tasks.next() {
+                Some(task) => task,
                 None => {
+                    has_unprocessed_tasks = false;
+                    // No more tasks, we're done
                     break;
                 }
-            }
+            };
         }
 
         if num_tasks > 0 {
@@ -215,8 +219,8 @@ where
             account.realloc(0, false)?;
         }
 
-        // If we've processed all tasks, we can exit
-        if num_tasks == 0 || tasks.next().is_none() {
+        // If we have no more tasks to process, we can exit
+        if num_tasks == 0 || !has_unprocessed_tasks {
             break;
         }
     }