fix building websockets url to support more use cases #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzothZephyr
changed the title
ChewingGlass
approved these changes
May 27, 2025
Contributor
|
@AzothZephyr You need to have verified signatures enabled on github and then amend you commit. Then I can merge this |
AzothZephyr
force-pushed
the
fix-ws-port-conversion
branch
from
3e168b9 to
933df9a
Compare
AzothZephyr
force-pushed
the
fix-ws-port-conversion
branch
from
933df9a to
d6b2aab
Compare
Contributor
Author
|
@ChewingGlass should be all set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change fixes building websockets url from an IP such as http://10.1.1.240:8899 or fqdn such as http://drinkmorewater.com:8899 by removing 127.0.0.1 from the replace call when the crank turner is building the websockets url. previously, it was limited to only being able to run on an rpc, validator, host with local port forwarding to an rpc/validator, or where an instance of nginx handles the routing by protocol such as paid services like helius or shyft.