fix(helix-view): regression in force write (#15238)

Author: matoous

helix-term/tests/test/commands/write.rs

@@ -370,6 +370,33 @@ async fn test_write_scratch_to_new_path() -> anyhow::Result<()> {
     Ok(())
 }
 
+#[tokio::test(flavor = "multi_thread")]
+async fn test_write_scratch_to_new_path_force_creates_file() -> anyhow::Result<()> {
+    let dir = tempfile::tempdir()?;
+    let new_path = dir.path().join("new-file.txt");
+
+    test_key_sequence(
+        &mut AppBuilder::new().build()?,
+        Some(format!("ihello<esc>:w! {}<ret>", new_path.to_string_lossy()).as_ref()),
+        Some(&|app| {
+            assert!(!app.editor.is_err());
+
+            let mut docs: Vec<_> = app.editor.documents().collect();
+            assert_eq!(1, docs.len());
+
+            let doc = docs.pop().unwrap();
+            assert_eq!(Some(&path::normalize(&new_path)), doc.path());
+        }),
+        false,
+    )
+    .await?;
+
+    let file_content = std::fs::read_to_string(&new_path)?;
+    assert_eq!(file_content, LineFeedHandling::Native.apply("hello"));
+
+    Ok(())
+}
+
 #[tokio::test(flavor = "multi_thread")]
 async fn test_write_scratch_no_path_fails() -> anyhow::Result<()> {
     helpers::test_key_sequence_with_input_text(

helix-view/src/document.rs

@@ -1035,7 +1035,11 @@ impl Document {
 
             // Assume it is a hardlink to prevent data loss if the metadata cant be read (e.g. on certain Windows configurations)
             let is_hardlink = helix_stdx::faccess::hardlink_count(&write_path).unwrap_or(2) > 1;
-            let is_symlink = tokio::fs::symlink_metadata(&write_path).await?.is_symlink();
+            let is_symlink = match tokio::fs::symlink_metadata(&write_path).await {
+                Ok(meta) => meta.is_symlink(),
+                Err(err) if err.kind() == std::io::ErrorKind::NotFound => false,
+                Err(err) => return Err(err.into()),
+            };
             let must_copy = is_hardlink || is_symlink;
             let backup = if path.exists() && atomic_save {
                 let path_ = write_path.clone();