Add insert-pipe and append-pipe commands.

Both commands behave similary to `insert-output` and `append-output` commands, except that they also pipe the selections into the command.

This PR is inspired by the now closed PR #12590.

Author: mlen

helix-term/src/commands.rs

@@ -600,6 +600,8 @@ impl MappableCommand {
         dap_disable_exceptions, "Disable exception breakpoints",
         shell_pipe, "Pipe selections through shell command",
         shell_pipe_to, "Pipe selections into shell command ignoring output",
+        shell_pipe_insert, "Insert pipe command output before selections",
+        shell_pipe_append, "Append pipe command output after selections",
         shell_insert_output, "Insert shell command output before selections",
         shell_append_output, "Append shell command output after selections",
         shell_keep_pipe, "Filter selections with shell predicate",
@@ -6436,6 +6438,8 @@ enum ShellBehavior {
     Ignore,
     Insert,
     Append,
+    InsertPipe,
+    AppendPipe,
 }
 
 fn shell_pipe(cx: &mut Context) {
@@ -6446,6 +6450,14 @@ fn shell_pipe_to(cx: &mut Context) {
     shell_prompt_for_behavior(cx, "pipe-to:".into(), ShellBehavior::Ignore);
 }
 
+fn shell_pipe_insert(cx: &mut Context) {
+    shell_prompt_for_behavior(cx, "insert-pipe:".into(), ShellBehavior::InsertPipe);
+}
+
+fn shell_pipe_append(cx: &mut Context) {
+    shell_prompt_for_behavior(cx, "append-pipe:".into(), ShellBehavior::AppendPipe);
+}
+
 fn shell_insert_output(cx: &mut Context) {
     shell_prompt_for_behavior(cx, "insert-output:".into(), ShellBehavior::Insert);
 }
@@ -6560,7 +6572,7 @@ async fn shell_impl_async(
 
 fn shell(cx: &mut compositor::Context, cmd: &str, behavior: &ShellBehavior) {
     let pipe = match behavior {
-        ShellBehavior::Replace | ShellBehavior::Ignore => true,
+        ShellBehavior::Replace | ShellBehavior::Ignore | ShellBehavior::InsertPipe | ShellBehavior::AppendPipe => true,
         ShellBehavior::Insert | ShellBehavior::Append => false,
     };
 
@@ -6605,8 +6617,8 @@ fn shell(cx: &mut compositor::Context, cmd: &str, behavior: &ShellBehavior) {
 
         let (from, to, deleted_len) = match behavior {
             ShellBehavior::Replace => (range.from(), range.to(), range.len()),
-            ShellBehavior::Insert => (range.from(), range.from(), 0),
-            ShellBehavior::Append => (range.to(), range.to(), 0),
+            ShellBehavior::Insert | ShellBehavior::InsertPipe => (range.from(), range.from(), 0),
+            ShellBehavior::Append | ShellBehavior::AppendPipe => (range.to(), range.to(), 0),
             _ => (range.from(), range.from(), 0),
         };
 

helix-term/src/commands/typed.rs

@@ -2524,6 +2524,14 @@ fn insert_output(
     Ok(())
 }
 
+fn append_pipe(cx: &mut compositor::Context, args: Args, event: PromptEvent) -> anyhow::Result<()> {
+    pipe_impl(cx, args, event, &ShellBehavior::AppendPipe)
+}
+
+fn insert_pipe(cx: &mut compositor::Context, args: Args, event: PromptEvent) -> anyhow::Result<()> {
+    pipe_impl(cx, args, event, &ShellBehavior::InsertPipe)
+}
+
 fn pipe_to(cx: &mut compositor::Context, args: Args, event: PromptEvent) -> anyhow::Result<()> {
     pipe_impl(cx, args, event, &ShellBehavior::Ignore)
 }
@@ -3857,6 +3865,22 @@ pub const TYPABLE_COMMAND_LIST: &[TypableCommand] = &[
         completer: SHELL_COMPLETER,
         signature: SHELL_SIGNATURE,
     },
+    TypableCommand  {
+        name: "insert-pipe",
+        aliases: &[],
+        doc: "Pipe each selection to the shell command, insert output before selction.",
+        fun: insert_pipe,
+        completer: SHELL_COMPLETER,
+        signature: SHELL_SIGNATURE,
+    },
+    TypableCommand  {
+        name: "append-pipe",
+        aliases: &[],
+        doc: "Pipe each selection to the shell command, append output after selction.",
+        fun: append_pipe,
+        completer: SHELL_COMPLETER,
+        signature: SHELL_SIGNATURE,
+    },
     TypableCommand {
         name: "run-shell-command",
         aliases: &["sh", "!"],

helix-term/tests/test/commands.rs

@@ -271,6 +271,38 @@ async fn test_multi_selection_shell_commands() -> anyhow::Result<()> {
     ))
     .await?;
 
+    // insert-pipe
+    test((
+        indoc! {"\
+            #[|lorem]#
+            #(|ipsum)#
+            #(|dolor)#
+            "},
+        ":insert-pipe cat<ret>",
+        indoc! {"\
+            #[|lorem]#lorem
+            #(|ipsum)#ipsum
+            #(|dolor)#dolor
+            "},
+    ))
+    .await?;
+
+    // append-pipe
+    test((
+        indoc! {"\
+            #[|lorem]#
+            #(|ipsum)#
+            #(|dolor)#
+            "},
+        ":insert-pipe cat<ret>",
+        indoc! {"\
+            lorem#[|lorem]#
+            ipsum#(|ipsum)#
+            dolor#(|dolor)#
+            "},
+    ))
+    .await?;
+
     Ok(())
 }