Skip to content

Commit cd9092f

Browse files
committed
ci: fix frozen bootloader references
This patch hopefully fixes the remaining references to the bootloader files. Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
1 parent 5f7a45e commit cd9092f

3 files changed

Lines changed: 19 additions & 6 deletions

File tree

.github/workflows/attach_release_assets.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ jobs:
3838
files: |
3939
hello.nrfcloud.com-*.*
4040
connectivity-bridge*.*
41+
nrf91-bl-*.hex
42+
nrf53-bl-*.hex
4143
4244
- name: Trigger workflow that publishes firmware bundles to nRF Cloud
4345
working-directory: .github/workflows

.github/workflows/build.yml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,12 @@ jobs:
118118
- name: Rename artifacts
119119
working-directory: thingy91x-oob/app/build
120120
run: |
121+
cp ../../../nrf91-bl-*.hex .
122+
# Overwrite the bootloader part with the frozen version
121123
python3 ../../../zephyr/scripts/build/mergehex.py -o \
122124
hello.nrfcloud.com-${{ env.VERSION }}-thingy91x-nrf91.hex \
123125
merged.hex \
124-
../../../nrf91-bl-v*.hex \
126+
nrf91-bl-*.hex \
125127
--overlap replace
126128
cp app/zephyr/.config hello.nrfcloud.com-${{ env.VERSION }}-thingy91x-nrf91.config
127129
cp app/zephyr/zephyr.signed.bin hello.nrfcloud.com-${{ env.VERSION }}-thingy91x-nrf91-update-signed.bin
@@ -137,6 +139,7 @@ jobs:
137139
if-no-files-found: error
138140
path: |
139141
thingy91x-oob/app/build/hello.nrfcloud.com-*.*
142+
thingy91x-oob/app/build/nrf91-bl-*.hex
140143
141144
# Out-of-box debug firmware build
142145

@@ -156,7 +159,13 @@ jobs:
156159
if: ${{ inputs.build_debug }}
157160
working-directory: thingy91x-oob/app/build
158161
run: |
159-
cp merged.hex hello.nrfcloud.com-${{ env.VERSION }}+debug-thingy91x-nrf91.hex
162+
cp ../../../nrf91-bl-*.hex .
163+
# Overwrite the bootloader part with the frozen version
164+
python3 ../../../zephyr/scripts/build/mergehex.py -o \
165+
hello.nrfcloud.com-${{ env.VERSION }}+debug-thingy91x-nrf91.hex \
166+
merged.hex \
167+
nrf91-bl-*.hex \
168+
--overlap replace
160169
cp app/zephyr/.config hello.nrfcloud.com-${{ env.VERSION }}+debug-thingy91x-nrf91.config
161170
cp app/zephyr/zephyr.signed.bin hello.nrfcloud.com-${{ env.VERSION }}+debug-thingy91x-nrf91-update-signed.bin
162171
cp app/zephyr/zephyr.signed.hex hello.nrfcloud.com-${{ env.VERSION }}+debug-thingy91x-nrf91-update-signed.hex
@@ -173,7 +182,6 @@ jobs:
173182
path: |
174183
thingy91x-oob/app/build/hello.nrfcloud.com-*.*
175184
176-
177185
# Connectivity Bridge firmware build
178186

179187
- name: Build nrf53 firmware
@@ -183,6 +191,9 @@ jobs:
183191
184192
- name: Create nrf53 merged_domains HEX file
185193
run: |
194+
# check that bootloader hex files are present
195+
ls $(pwd)/nrf53-bl-v*-net.hex $(pwd)/nrf53-bl-v*-app.hex
196+
# merge hex files to app, net and merged variants, enforcing the frozen bootloader
186197
python3 zephyr/scripts/build/mergehex.py -o \
187198
$(pwd)/nrf/applications/connectivity_bridge/build/connectivity-bridge-${{ env.VERSION }}-thingy91x-nrf53-net.hex \
188199
$(pwd)/nrf/applications/connectivity_bridge/build/merged_CPUNET.hex \
@@ -202,6 +213,7 @@ jobs:
202213
run: |
203214
cp $(pwd)/nrf/applications/connectivity_bridge/build/dfu_application.zip \
204215
$(pwd)/nrf/applications/connectivity_bridge/build/connectivity-bridge-${{ env.VERSION }}-thingy91x-nrf53-dfu.zip
216+
cp nrf53-bl-*.hex $(pwd)/nrf/applications/connectivity_bridge/build/
205217
206218
- name: Upload artifact
207219
uses: actions/upload-artifact@v4
@@ -211,6 +223,7 @@ jobs:
211223
if-no-files-found: error
212224
path: |
213225
nrf/applications/connectivity_bridge/build/connectivity-bridge-*.*
226+
nrf/applications/connectivity_bridge/build/nrf53-bl-*.hex
214227
215228
# Bootloader update build
216229

@@ -238,8 +251,6 @@ jobs:
238251
path: |
239252
thingy91x-oob/hello.nrfcloud.com-*.*
240253
thingy91x-oob/connectivity-bridge-*.*
241-
nrf53-bl-*.hex
242-
nrf91-bl-*.hex
243254
244255
- name: Print run-id and fw version
245256
run: |

.github/workflows/on_target.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ jobs:
162162
NRF53_APP_HEX_FILE: artifacts/connectivity-bridge-${{ inputs.artifact_fw_version }}-thingy91x-nrf53-app.hex
163163
NRF53_APP_UPDATE_ZIP: artifacts/connectivity-bridge-${{ inputs.artifact_fw_version }}-thingy91x-nrf53-verbose.zip
164164
NRF53_BL_UPDATE_ZIP: artifacts/connectivity-bridge-${{ inputs.artifact_fw_version }}-thingy91x-nrf53-bootloader.zip
165-
NRF91_HEX_FILE: artifacts/hello.nrfcloud.com-${{ inputs.artifact_fw_version }}-thingy91x-nrf91-bootloader.hex
165+
NRF91_HEX_FILE: artifacts/nrf91-bl-v2.hex
166166
NRF91_APP_UPDATE_ZIP: artifacts/hello.nrfcloud.com-${{ inputs.artifact_fw_version }}-thingy91x-nrf91-dfu.zip
167167
NRF91_BL_UPDATE_ZIP: artifacts/hello.nrfcloud.com-${{ inputs.artifact_fw_version }}-thingy91x-nrf91-bootloader.zip
168168
LOG_FILENAME: oob_dfu_test_log

0 commit comments

Comments
 (0)