Not all apis removed from release

[olegtrautvein]

Hello.
We are using helm v3.7.2 + mapkubeapis v0.4.1
k8s node v1.24.9 (where old release version deployed) and v1.25.6 (where plugin executed)

On some releases plugin removes all removed apis, but one of this has removed only 4 of 5 apiVersion: policy/v1beta1\nkind: PodSecurityPolicy\n

There are logs of that execution:

/tmp $ helm-v3.7.2 mapkubeapis project-monitoring --namespace project 
2023/04/04 21:09:34 Release 'project-monitoring' will be checked for deprecated or removed Kubernetes APIs and will be updated if necessary to supported API versions.
2023/04/04 21:09:34 Get release 'project-monitoring' latest version.
2023/04/04 21:09:34 Check release 'project-monitoring' for deprecated or removed APIs...
2023/04/04 21:09:34 Found 4 instances of deprecated or removed Kubernetes API:
"apiVersion: policy/v1beta1
kind: PodSecurityPolicy
"
No supported API equivalent
2023/04/04 21:09:34 Finished checking release 'project-monitoring' for deprecated or removed APIs.
2023/04/04 21:09:34 Deprecated or removed APIs exist, updating release: project-monitoring.
2023/04/04 21:09:34 Set status of release version 'project-monitoring.v1' to 'superseded'.
2023/04/04 21:09:35 Release version 'project-monitoring.v1' updated successfully.
2023/04/04 21:09:35 Add release version 'project-monitoring.v2' with updated supported APIs.
2023/04/04 21:09:35 Release version 'project-monitoring.v2' added successfully.
2023/04/04 21:09:35 Release 'project-monitoring' with deprecated or removed APIs updated successfully to new version.
2023/04/04 21:09:35 Map of release 'project-monitoring' deprecated or removed APIs to supported versions, completed successfully.

I used the following command to get secret manifests:
kubectl get secret -n project sh.helm.release.v1.project-monitoring.v1 --template={{.data.release}} | base64 -d | base64 -d | gzip -d | jq -r .manifest > before.json

Please find before.yaml and after.yaml attached. I left only the beginning of the files where there are differents

May be it will useful information: release where plugin removed all three 'wrong' apis has exported secret size 71kb, but release where removed 4 of 5 has exported secret size 477kb and 3.2mb of decoded unzipped manifest field.

[olegtrautvein]

Hello. I found that one of subchart uses windows-style caret return. So, adding of instruction should help as urgent method, but it is better to support it in mapkubeapis plugin.
Removed API record to resolve this problem:

 - deprecatedAPI: "apiVersion: policy/v1beta1\r\nkind: PodSecurityPolicy\r\n"
    removedInVersion: "v1.25" 

Bad chart is victoria-metrics-cluster v0.9.46, it contains template 'app-monitoring/charts/vmcluster/templates/podsecuritypolicy.yaml' which not deleted by plugin

Adding the following code here

helm-mapkubeapis/pkg/v3/release.go

Line 47 in 403d3ad

var origManifest = releaseToMap.Manifest

should help:

        origManifest = strings.Replace(releaseToMap.Manifest, "\r\n", "\n", -1)

[evanstucker-hates-2fa]

I edited my ~/.local/share/helm/plugins/helm-mapkubeapis/config/Map.yaml, copied the entire array, pasted it, and replaced \n with \r\n in the duplicated block to make it catch both kinds of line endings.

[evanstucker-hates-2fa]

Also, this appears to be a duplicate of #82