fix(polylang): avoid suppressing filters for font queries

Copilot · sebastianthulin · web-flow · commit 509cc69b94c0 · 2026-04-14T11:45:09.000Z
Agent-Logs-Url: https://github.com/helsingborg-stad/Municipio/sessions/596c6b63-d545-41bd-9fd1-5cf348dc39ee Co-authored-by: sebastianthulin <797129+sebastianthulin@users.noreply.github.com>
diff --git a/library/Integrations/Polylang/ResolveFontAttachmentQueries.php b/library/Integrations/Polylang/ResolveFontAttachmentQueries.php
@@ -48,7 +48,6 @@ public function makeFontAttachmentQueryLanguageAgnostic(WP_Query $query): void
         }
 
         $query->set('lang', '');
-        $query->set('suppress_filters', true);
     }
 
     /**
diff --git a/library/Integrations/Polylang/ResolveFontAttachmentQueriesTest.php b/library/Integrations/Polylang/ResolveFontAttachmentQueriesTest.php
@@ -47,7 +47,7 @@ public function testMakeFontAttachmentQueryLanguageAgnosticUpdatesArrayMimeTypeQ
         $sut->makeFontAttachmentQueryLanguageAgnostic($query);
 
         static::assertSame('', $query->get('lang'));
-        static::assertTrue($query->get('suppress_filters'));
+        static::assertArrayNotHasKey('suppress_filters', $query->query_vars);
     }
 
     #[TestDox('makeFontAttachmentQueryLanguageAgnostic() updates font attachment queries with string mime types')]
@@ -64,7 +64,7 @@ public function testMakeFontAttachmentQueryLanguageAgnosticUpdatesStringMimeType
         $sut->makeFontAttachmentQueryLanguageAgnostic($query);
 
         static::assertSame('', $query->get('lang'));
-        static::assertTrue($query->get('suppress_filters'));
+        static::assertArrayNotHasKey('suppress_filters', $query->query_vars);
     }
 
     #[TestDox('makeFontAttachmentQueryLanguageAgnostic() does not update non-font attachment queries')]

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ public function makeFontAttachmentQueryLanguageAgnostic(WP_Query $query): void`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`$query->set('lang', '');`
`51`		`- $query->set('suppress_filters', true);`
`52`	`51`	`}`
`53`	`52`
`54`	`53`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function testMakeFontAttachmentQueryLanguageAgnosticUpdatesArrayMimeTypeQ`
`47`	`47`	`$sut->makeFontAttachmentQueryLanguageAgnostic($query);`
`48`	`48`
`49`	`49`	`static::assertSame('', $query->get('lang'));`
`50`		`- static::assertTrue($query->get('suppress_filters'));`
	`50`	`+ static::assertArrayNotHasKey('suppress_filters', $query->query_vars);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`#[TestDox('makeFontAttachmentQueryLanguageAgnostic() updates font attachment queries with string mime types')]`
`@@ -64,7 +64,7 @@ public function testMakeFontAttachmentQueryLanguageAgnosticUpdatesStringMimeType`
`64`	`64`	`$sut->makeFontAttachmentQueryLanguageAgnostic($query);`
`65`	`65`
`66`	`66`	`static::assertSame('', $query->get('lang'));`
`67`		`- static::assertTrue($query->get('suppress_filters'));`
	`67`	`+ static::assertArrayNotHasKey('suppress_filters', $query->query_vars);`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`#[TestDox('makeFontAttachmentQueryLanguageAgnostic() does not update non-font attachment queries')]`