Skip to content

Commit 1a4c5e8

Browse files
authored
Don't fail the release when the downloads server is unreachable (#475)
The "Release the book and website" workflow has been failing on every push to main. The book and website build fine, but the deploy step ("Copy book to downloads server") can't reach the host in SSH_HOST: ssh: connect to host *** port 22: Network unreachable rsync error: unexplained error (code 255) That's an infrastructure issue (server down / moved / firewalled), not a problem with the book. Mark both rsync deploy steps continue-on-error so a temporarily unreachable downloads server no longer fails the whole release - the book/website artifacts are still uploaded to GitHub. Also bump the deprecated actions flagged in the run annotations: - burnett01/rsync-deployments 7.0.2 -> v8 (inputs unchanged) - actions/checkout v3 -> v4 (Node 20 is being forced to Node 24)
1 parent 9a7ccd4 commit 1a4c5e8

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/release-book-website.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
packages: write
1717
steps:
1818
- name: Checkout repository
19-
uses: actions/checkout@v3
19+
uses: actions/checkout@v4
2020

2121
- name: Log in to the Container registry
2222
uses: docker/login-action@65b78e6e13532edd9afa3aa52ac7964289d1a9c1
@@ -40,7 +40,7 @@ jobs:
4040
runs-on: ubuntu-latest
4141
steps:
4242
- name: Set up git repository
43-
uses: actions/checkout@v3
43+
uses: actions/checkout@v4
4444
- name: Print dependency versions
4545
uses: addnab/docker-run-action@v3
4646
with:
@@ -66,7 +66,11 @@ jobs:
6666
cd /app/book
6767
make -j -O bake
6868
- name: Copy book to downloads server
69-
uses: burnett01/rsync-deployments@7.0.2
69+
# Best-effort: a temporarily unreachable downloads server must not
70+
# fail the whole release. Book/website artifacts are still uploaded
71+
# to GitHub below.
72+
continue-on-error: true
73+
uses: burnett01/rsync-deployments@v8
7074
with:
7175
switches: "-avzr"
7276
remote_host: ${{ secrets.SSH_HOST }}
@@ -83,7 +87,9 @@ jobs:
8387
book/book_serif/book.pdf
8488
book/book-epub/book.epub
8589
- name: Copy website to downloads server
86-
uses: burnett01/rsync-deployments@7.0.2
90+
# Best-effort, same rationale as the book deploy above.
91+
continue-on-error: true
92+
uses: burnett01/rsync-deployments@v8
8793
with:
8894
switches: "-avzr --delete"
8995
remote_host: ${{ secrets.SSH_HOST }}

0 commit comments

Comments
 (0)