Merge pull request #13 from henribru/v14-support

Author: henribru

README.md

@@ -3,13 +3,11 @@
 [![PyPI version](https://badge.fury.io/py/google-ads-stubs.svg)](https://badge.fury.io/py/google-ads-stubs)
 
 This package provides type stubs for the [Google Ads API Client Library for Python](https://github.com/googleads/google-ads-python). 
-It's currently compatible with v.9.0.0 of this library. It allows you to type check usage of the library with e.g. [mypy](http://mypy-lang.org/) and will also improve autocomplete in many editors.
+It's currently compatible with v14.0.0 of this library. It allows you to type check usage of the library with e.g. [mypy](http://mypy-lang.org/) and will also improve autocomplete in many editors.
 
 **This is in no way affiliated with Google.**
 
-The stubs for protobuf messages were created by [mypy-protobuf](https://github.com/dropbox/mypy-protobuf).
-The rest were created either by hand or by self-made scripts, with the output of MyPy's `stubgen` as
-a starting point.
+Most stubs were created automatically by [stubgen](https://mypy.readthedocs.io/en/stable/stubgen.html), the rest are handwritten or generated by self-made scripts.
 
 If you find incorrect annotations, please create an issue. Contributions for fixes are also welcome.
 
@@ -29,28 +27,23 @@ the object directly.
 # Replace this:
 campaign_operation = client.get_type('CampaignOperation')
 # With this:
-from google.ads.google_ads.v3.types import CampaignOperation
+from google.ads.googleads.v8 import CampaignOperation
 campaign_operation: CampaignOperation = client.get_type('CampaignOperation')
 # Or this:
-from google.ads.google_ads.v3.types import CampaignOperation
+from google.ads.googleads.v8 import CampaignOperation
 campaign_operation = CampaignOperation()
 
 # Replace this:
 google_ads_service = client.get_service('GoogleAdsService')
 # With this:
-from google.ads.google_ads.v3.services import GoogleAdsServiceClient
+from google.ads.googleads.v8 import GoogleAdsServiceClient
 google_ads_service: GoogleAdsServiceClient = client.get_service('GoogleAdsService')
 ```
 
 While it is technically possible to type these methods using a combination of overloading and literal types,
-this is not included in these stubs. The reason is that it requires about 10,000 overloads, which, while simple
-to generate, slows type checking to a crawl.
+this is not included in these stubs. The reason is that it requires about 10,000 overloads, which makes most typecheckers fairly slow.
 
-This package does not provide complete type annotations, although it should cover what's used by most developers.
-The bare output from `stubgen` is used by the ransport classes. These may be typed in the future if there is a need for it.
+Another big caveat since v8.0.0 of this package is that the attributes and constructor arguments of the protobuf messages are all typed as `Any` instead of their proper types. This is due to `google-ads-python` switching from raw protobuf message classes to `proto-plus` classes. Better types for these might be introduced in the future. `GoogleAdsClient.enums` is also typed as `Any`.
 
-Some service methods allow you to pass in either a protobuf message or a dictionary for certain arguments.
-There is no check that the dictionary conforms to the message structure, as this would require a `TypedDict` subclass
-for each message.
 
-Note that if you're using Mypy you need to use the `--namespace-packages` option as `google` and `google.ads` are namespace packages.
+Note that if you're using Mypy you need to use the `--namespace-packages` option as `google` and `google.ads` are namespace packages.