[Bug]: beszel Linux install script needs some work

[kode54]

Component

Agent

Description

The agent install script has some shortcomings, particularly affecting OpenWrt.

1. The env line should have all of the environment variables space-delimited on one line. Somehow, having more than two variables on separate lines is breaking it.
2. To generate or usermod the user entry, opkg should install both shadow-useradd and shadow-usermod. I'm not sure if coreutils is needed if these are installed.

Expected Behavior

The script should install the daemon and actually work.

Steps to Reproduce

1. Copy Linux install command
2. Paste to latest OpenWrt 24.10.2 shell
3. Observe as daemon no longer launches

Category

Installation

Affected Metrics

Other

OS / Architecture

linux/amd64 (agent), linux/aarch64 (agent)

Beszel version

0.12.1

Installation method

Binary

Configuration

Do I need to paste my tokens here? It's failing to detect the KEY variable if three or four env variables are all set on separate lines instead of being globbed onto one line.

The tools will also allow creating and maintaining the shadow user for the daemon to run as.

Hub Logs

Agent Logs

[evrial]

same issue here

Downloading https://fw.gl-inet.com/releases/mt798x/kmod-4.5.7/aarch64_cortex-a53/mediatek/mt7986/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_core
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/glinet/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_gli_pub
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_gli_packages
Updating database.
Database update completed.
Installing tar (1.32-3) to root...
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/tar_1.32-3_aarch64_cortex-a53.ipk
Installing xz-utils (5.2.5-3) to root...
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/xz-utils_5.2.5-3_aarch64_cortex-a53.ipk
Installing liblzma (5.2.5-3) to root...
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/liblzma_5.2.5-3_aarch64_cortex-a53.ipk
Installing xz (5.2.5-3) to root...
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/xz_5.2.5-3_aarch64_cortex-a53.ipk
Installing bzip2 (1.0.8-1) to root...
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/bzip2_1.0.8-1_aarch64_cortex-a53.ipk
Package curl (7.83.1-4.1) installed in root is up to date.
Package coreutils (8.32-6) installed in root is up to date.
Configuring liblzma.
Configuring bzip2.
Configuring xz-utils.
Configuring xz.
Configuring tar.
Updating database.
Database update completed.
Creating a dedicated user for the Beszel Agent service...
/tmp/install-agent.sh: line 354: useradd: not found
/tmp/install-agent.sh: line 357: getent: not found
Creating the directory for the Beszel Agent...
chown: unknown user/group beszel:beszel
Downloading and installing the agent...
Downloading and installing agent version 0.12.1 from https://github.com ...
#=#=-  #       #                                                                                                                                                                                                                                               #=O#-     #        #                                                                                                                                                                                                                                           -#O=- #      #          #                                                                                                                                                                                                                             ######################################################################################################################################################################################################################################################### 100.0%
chown: unknown user/group beszel:beszel
Creating procd init script service for OpenWRT...
/tmp/install-agent.sh: line 576: service: not found
/tmp/install-agent.sh: line 579: service: not found

Would you like to enable automatic daily updates for beszel-agent? (y/n): y
Setting up daily automatic updates for beszel-agent...

Automatic daily updates have been enabled.
Error: The Beszel Agent service is not running.
/tmp/install-agent.sh: line 609: service: not found

cat /etc/os-release
NAME="OpenWrt"
VERSION="21.02-SNAPSHOT"
ID="openwrt"
ID_LIKE="lede openwrt"
PRETTY_NAME="OpenWrt 21.02-SNAPSHOT"
VERSION_ID="21.02-snapshot"
HOME_URL="https://openwrt.org/"
BUG_URL="https://bugs.openwrt.org/"
SUPPORT_URL="https://forum.openwrt.org/"
BUILD_ID="r15812+1085-46b6ee7ffc"
OPENWRT_BOARD="mediatek/mt7986"
OPENWRT_ARCH="aarch64_cortex-a53"
OPENWRT_TAINTS="busybox override"
OPENWRT_DEVICE_MANUFACTURER="OpenWrt"
OPENWRT_DEVICE_MANUFACTURER_URL="https://openwrt.org/"
OPENWRT_DEVICE_PRODUCT="Generic"
OPENWRT_DEVICE_REVISION="v0"
OPENWRT_RELEASE="OpenWrt 21.02-SNAPSHOT r15812+1085-46b6ee7ffc"

[henrygd]

Thanks, I made some updates to the script. Let me know if you have better luck now.

We'll try updating /etc/passwd and /etc/group directly rather than installing more packages. coreutils is necessary for sha256sum IIRC.

https://github.com/henrygd/beszel/compare/60a6ae2/d4bb0a0

[evrial]

The issue with service command remains. https://openwrt.org/docs/guide-user/base-system/managing_services#command-line_instructions
I fixed it and it works fine but update service is missing at /etc/init.d/beszel-agent-update
rc-update rc-service not present in openwrt
I think ideally script should check service with package_installed and terminate if something is missing
Also 24 version has apk package manager, so same as alpine, but need also check with package_installed apk

Downloading https://fw.gl-inet.com/releases/mt798x/kmod-4.5.7/aarch64_cortex-a53/mediatek/mt7986/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_core
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/glinet/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_gli_pub
Downloading https://fw.gl-inet.com/releases/mt798x/packages-4.5/aarch64_cortex-a53/packages/Packages.gz
Updated list of available packages in /var/opkg-lists/glinet_gli_packages
Updating database.
Database update completed.
Package tar (1.32-3) installed in root is up to date.
Package curl (7.83.1-4.1) installed in root is up to date.
Package coreutils (8.32-6) installed in root is up to date.
Updating database.
Database update completed.
Creating a dedicated user for the Beszel Agent service...
Downloading and installing the agent...
Downloading and installing agent version 0.12.1 from https://github.com ...
#################################################################################################################################################################################### 100.0%
Creating procd init script service for OpenWRT...
/tmp/install-agent.sh: line 599: service: not found
/tmp/install-agent.sh: line 602: service: not found

Would you like to enable automatic daily updates for beszel-agent? (y/n): y
Setting up daily automatic updates for beszel-agent...

Automatic daily updates have been enabled.
Error: The Beszel Agent service is not running.
/tmp/install-agent.sh: line 632: service: not found

[evrial]

PR with fix #1005

[henrygd]

@evrial Merged, thanks very much!

[henrygd]

Closing as completed after evrial's PR, but let me know if any further changes are needed.