HealpixMapper write `deconv` metadata on map creation, not on deconvolution

[ntessore]

There is a potential pitfall in the HealpixMapper when working with maps that haven't been created by the same mapper: the deconv metadata key is written into the map metadata when a map is created. Instead, it should be written into the alm metadata when a map is transformed.

[JaimeRZP]

heracles/heracles/healpy.py

Line 201 in 682f66e

update_metadata(alm, **md)

I think we are already doing this no?

[ntessore]

The problem is here:

mapper1 = HealpixMapper(..., deconvolve=True)
m = mapper1.create(...)  # map has deconvolve=True metadata
mapper2 = HealpixMapper(..., deconvolve=False)
alm = mapper2.transform(m)  # alm was computed without deconvolve
print(alm.dtype.metadata)  # has deconvolve=True