Skip to content

Fix suggestion to UAF in eval_else #868

@IliaKash1

Description

@IliaKash1

Hello, i have found the UAF which was also mentioned in #856, #853, #763, with the most complete explanation of the cause and reproduction steps present in #853.

At the same time, a fix is yet to be suggested, so i came up with the following: just copying the popped values so that the reallocation of the state does not impact them.

fix_uaf.txt

It fixes the error and does not cause unit tests to fail. Nonetheless, i can't be sure it does not break something i did not notice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions