Handle aliases for 3p deps on 1p crates

Author: dzbarsky

rs/extensions.bzl

@@ -993,7 +993,9 @@ RESOLVED_PLATFORMS = select({{
             if not bazel_target:
                 bazel_target = "//" + paths.join(workspace_package, _normalize_path(dep["path"]).removeprefix(repo_root + "/"))
 
-            if dep.get("path"):
+            if dep.get("rename"):
+                aliases[bazel_target] = dep["rename"].replace("-", "_")
+            elif dep.get("path"):
                 aliases[bazel_target] = dep["name"].replace("-", "_")
 
             target = dep.get("target")

test/BUILD.bazel

@@ -3,6 +3,7 @@ load("@rules_rs//rs:rust_binary.bzl", "rust_binary")
 load("@rules_shell//shell:sh_test.bzl", "sh_test")
 load("@target_workspace_dep_feature//:data.bzl", target_workspace_dep_feature_dep_data = "DEP_DATA")
 load("@workspace_hyphen_dep_aliases//:defs.bzl", workspace_hyphen_dep_aliases_aliases = "aliases")
+load("@workspace_renamed_path_dep_aliases//:defs.bzl", workspace_renamed_path_dep_aliases_aliases = "aliases")
 load("//:verify_aliases.bzl", "verify_alias", "verify_crate_feature_absent", "verify_dep_absent")
 
 sh_test(
@@ -135,6 +136,13 @@ verify_alias(
     expected_label = "//workspace_hyphen_dep_aliases/dep-crate",
 )
 
+verify_alias(
+    name = "verify_workspace_renamed_path_dep_aliases",
+    aliases = workspace_renamed_path_dep_aliases_aliases(package_name = "workspace_renamed_path_dep_aliases/consumer"),
+    expected_alias = "renamed_dep",
+    expected_label = "//workspace_renamed_path_dep_aliases/dep-crate",
+)
+
 genrule(
     name = "verify_workspace_member_annotation_features",
     srcs = [":workspace_member_annotation_features_dep_leaf_deps"],
@@ -184,6 +192,7 @@ filegroup(
         ":verify_target_workspace_dep_feature_dep_absent",
         ":verify_target_workspace_dep_feature_feature_absent",
         ":verify_workspace_hyphen_dep_aliases",
+        ":verify_workspace_renamed_path_dep_aliases",
         ":verify_workspace_member_annotation_features",
         "@binaries//:protoc-gen-prost__protoc-gen-prost",
     ] + select({

test/MODULE.bazel

@@ -98,6 +98,7 @@ TESTS = [
     "workspace_member_annotation_features",
     "workspace_path_dependency",
     "workspace_hyphen_dep_aliases",
+    "workspace_renamed_path_dep_aliases",
     "binaries",
     "uv",
 ]

test/workspace_renamed_path_dep_aliases/Cargo.lock

@@ -0,0 +1,3 @@
+[workspace]
+members = ["consumer", "dep-crate"]
+resolver = "2"

test/workspace_renamed_path_dep_aliases/Cargo.toml

@@ -0,0 +1,9 @@
+load("@rules_rs//rs:rust_test.bzl", "rust_test")
+load("@workspace_renamed_path_dep_aliases//:defs.bzl", "aliases", "all_crate_deps")
+
+rust_test(
+    name = "consumer_test",
+    aliases = aliases(),
+    srcs = ["src/lib.rs"],
+    deps = all_crate_deps(normal = True),
+)

test/workspace_renamed_path_dep_aliases/consumer/BUILD.bazel

@@ -0,0 +1,7 @@
+[package]
+name = "consumer"
+version = "0.1.0"
+edition = "2024"
+
+[dependencies]
+renamed-dep = { package = "dep-crate", path = "../dep-crate" }

test/workspace_renamed_path_dep_aliases/consumer/Cargo.toml

@@ -0,0 +1,11 @@
+pub fn consume() -> &'static str {
+    renamed_dep::dep_value()
+}
+
+#[cfg(test)]
+mod tests {
+    #[test]
+    fn dependency_is_linked() {
+        assert_eq!(super::consume(), "dep");
+    }
+}

test/workspace_renamed_path_dep_aliases/consumer/src/lib.rs

@@ -0,0 +1,13 @@
+load("@rules_rs//rs:rust_library.bzl", "rust_library")
+load("@workspace_renamed_path_dep_aliases//:defs.bzl", "aliases", "all_crate_deps")
+
+package(default_visibility = ["//visibility:public"])
+
+rust_library(
+    name = "dep-crate",
+    srcs = ["src/lib.rs"],
+    crate_name = "dep_crate",
+    edition = "2024",
+    aliases = aliases(),
+    deps = all_crate_deps(normal = True),
+)

test/workspace_renamed_path_dep_aliases/dep-crate/BUILD.bazel

@@ -0,0 +1,4 @@
+[package]
+name = "dep-crate"
+version = "0.1.0"
+edition = "2024"