Clippy validates all dependencies?

[Yatekii]

Is clippy validating all dependencies - do I understand this right? Can I get rid of this behavior? It is very pointless to be honest as I will never go fix those clippy lints.

[dzbarsky]

@Yatekii hmm, that's a little surprising, given rust_crate should be adding tags to all the generated targets which should result in skipping clippy and rustfmt aspect propagation

Emperically it does look like the tags get rendered properly:

➜  test git:(zbarsky/symlink) bazel query --output=build @@rules_rs++crate+many_workspace_deps__zip-7.4.0//:zip
INFO: Invocation ID: 9dad20ee-6072-4b03-ba4f-836900c4f497
INFO: Streaming build results to: https://app.buildbuddy.io/invocation/9dad20ee-6072-4b03-ba4f-836900c4f497
# /Users/dzbarsky/Library/Caches/bazel/_bazel_dzbarsky/16a3c4547ef278628dec1184581db8ea/external/rules_rs++crate+many_workspace_deps__zip-7.4.0/BUILD.bazel:5:11
rust_library(
  name = "zip",
  visibility = ["//visibility:public"],
  tags = ["crate-name=zip", "manual", "noclippy", "norustfmt"],

So I'm curious what's going on with your setup - could you help explain what you're seeing?

[Yatekii]

I think this is a clear case of me holding bazel wrong (I am very new).

I have in my .bazelrc:

build:clippy --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
build:clippy --output_groups=+clippy_checks

And I run clippy with bazel build //... --config=clippy.
This seems to run clippy for all the packages.

Also, I would like rust-analyzer to always show clippy lints on every save and that's currently only possible by actively voiding the cache with --modify_execution_info=Clippy=+no-cache, which is not great because it rebuilds for a while.

If you could help me here that would be amazing :) Thanks a lot!

[dzbarsky]

Would you mind making a git repo showing the problem so I can play with it?

[Yatekii]

I can try and make a repro in a bit, yes, thanks! :)