Skip to content

virtio: PCI BAR mapping may be accessing invalid slots #1392

New issue
New issue
Closed
#1403
Closed
virtio: PCI BAR mapping may be accessing invalid slots#1392
#1403
@cagatay-y

Description

@cagatay-y
cagatay-y
opened on Sep 19, 2024

According to the pci-types documentation, the EndpointHeader::bar function should not be called on slots that make up the second part of a 64-bit BAR. However, map_bar_mem calls the function (indirectly) for all slots in the maximum BAR count range, without checking if the previous BAR was 64-bits.

kernel/src/drivers/virtio/env.rs

Lines 33 to 41 in 0245c53

pub(crate) fn map_bar_mem(
device: &PciDevice<PciConfigRegion>,
) -> Result<Vec<VirtioPciBar>, PciError> {
let mapped_bars: Vec<VirtioPciBar> = (0..u8::try_from(MAX_BARS).unwrap())
.filter_map(|i| {
device
.memory_map_bar(i, true)
.map(|(addr, size)| (i, addr, size))
})

Additionally, it seems like the BARs are always 64-bit based on the lines below:

kernel/src/drivers/pci.rs

Lines 147 to 150 in 0245c53

if width != 64 {
warn!("Currently only mapping of 64 bit bars is supported!");
return None;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions